[Mac] Hover/Active Omnibox Icon States for Secondary UI MD

chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h"
 
 #include "base/bind.h"
 #import "base/mac/mac_util.h"
 #include "base/memory/ptr_util.h"
 #include "base/stl_util.h"
@@ skipping 570 matching lines @@
   return [[field_ window] inIncognitoModeWithSystemTheme];
 }
 
 LocationBarDecoration* LocationBarViewMac::GetPageInfoDecoration() const {
   if (security_state_bubble_decoration_->IsVisible())
     return security_state_bubble_decoration_.get();
 
   return location_icon_decoration_.get();
 }
 
+LocationBarDecoration* LocationBarViewMac::GetContentSettingDecoration(
+    NSPoint anchor) const {
+  NSPoint anchor_in_view =
+      ui::ConvertPointFromScreenToWindow([field_ window], anchor);

[tapted, 2017/05/21 08:15:28]

This kind of hit testing is usually good to avoid - it can lead to less robust
solutions. Eg there are already issues when bubbles pop up whilst an NSWindow is
being actively dragged by the user -- Cocoa doesn't give continuous updates to
[window frame] until the window is released, since the drag events are
intercepted by the window server process. Mapping from screen to window
coordinates can do weird things in these cases.

[spqchan, 2017/05/23 06:52:37]

That makes sense, I'll avoid this

+  for (const auto& decoration : content_setting_decorations_) {
+    if (decoration->IsVisible() &&
+        NSEqualPoints([field_ arrowAnchorPointForDecoration:decoration.get()],
+                      anchor_in_view)) {
+      return decoration.get();
+    }
+  }
+
+  return nullptr;
+}
+
 NSImage* LocationBarViewMac::GetKeywordImage(const base::string16& keyword) {
   const TemplateURL* template_url = TemplateURLServiceFactory::GetForProfile(
       profile())->GetTemplateURLForKeyword(keyword);
   if (template_url &&
       (template_url->type() == TemplateURL::OMNIBOX_API_EXTENSION)) {
     return extensions::OmniboxAPI::Get(profile())->
         GetOmniboxIcon(template_url->GetExtensionId()).AsNSImage();
   }
 
   SkColor icon_color =
@@ skipping 204 matching lines @@
     OnDecorationsChanged();
 }
 
 std::vector<NSView*> LocationBarViewMac::GetDecorationAccessibilityViews() {
   std::vector<LocationBarDecoration*> decorations = GetDecorations();
   std::vector<NSView*> views;
   for (auto* decoration : decorations)
     views.push_back(decoration->GetAccessibilityView());
   return views;
 }