Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2882523003: Add forEachLibraryMember and forEachConstructor to ElementEnvironment (Closed)

Created:
3 years, 7 months ago by Johnni Winther
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add forEachLibraryMember and forEachConstructor to ElementEnvironment - for testing equivalence on library members and constructors R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/7d27e55c2ce80504d9c874d615378d63bb5778dc

Patch Set 1 #

Total comments: 4

Patch Set 2 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -4 lines) Patch
M pkg/compiler/lib/src/common_elements.dart View 2 chunks +7 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/kernel/element_map_impl.dart View 7 chunks +51 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution_strategy.dart View 3 chunks +23 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/equivalence/check_functions.dart View 1 2 chunks +58 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 7 months ago (2017-05-12 11:42:59 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2882523003/diff/1/tests/compiler/dart2js/equivalence/check_functions.dart File tests/compiler/dart2js/equivalence/check_functions.dart (right): https://codereview.chromium.org/2882523003/diff/1/tests/compiler/dart2js/equivalence/check_functions.dart#newcode548 tests/compiler/dart2js/equivalence/check_functions.dart:548: Expect.isTrue(constructors2.contains(constructor2), maybe use a Set for constructors2 instead? ...
3 years, 7 months ago (2017-05-12 16:48:38 UTC) #3
Johnni Winther
https://codereview.chromium.org/2882523003/diff/1/tests/compiler/dart2js/equivalence/check_functions.dart File tests/compiler/dart2js/equivalence/check_functions.dart (right): https://codereview.chromium.org/2882523003/diff/1/tests/compiler/dart2js/equivalence/check_functions.dart#newcode548 tests/compiler/dart2js/equivalence/check_functions.dart:548: Expect.isTrue(constructors2.contains(constructor2), On 2017/05/12 16:48:38, Siggi Cherem (dart-lang) wrote: > ...
3 years, 7 months ago (2017-05-15 07:55:51 UTC) #4
Johnni Winther
3 years, 7 months ago (2017-05-15 07:59:49 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
7d27e55c2ce80504d9c874d615378d63bb5778dc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698