ui/views/controls/webview/web_dialog_view.h - Issue 2882513005: Propagate opener to BackgroundsContents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/webview/web_dialog_view.h

Issue 2882513005: Propagate opener to BackgroundsContents. (Closed)

Patch Set: Added (and re-enabled) tests. Suppressed opener propagation in one case. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/webview/web_dialog_view.h

diff --git a/ui/views/controls/webview/web_dialog_view.h b/ui/views/controls/webview/web_dialog_view.h

index 6ece059d701ad3acc10f57309972673ca8ce1b5a..90795eb57fc94f6eb54d4e5711e6abda11371590 100644

--- a/ui/views/controls/webview/web_dialog_view.h

+++ b/ui/views/controls/webview/web_dialog_view.h

@@ -116,6 +116,7 @@ class WEBVIEW_EXPORT WebDialogView : public views::ClientView,

bool* proceed_to_fire_unload) override;

bool ShouldCreateWebContents(

content::WebContents* web_contents,

+ content::RenderFrameHost* opener,

content::SiteInstance* source_site_instance,

int32_t route_id,

int32_t main_frame_route_id,