extensions/browser/guest_view/extension_options/extension_options_guest.cc - Issue 2882513005: Propagate opener to BackgroundsContents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/extension_options/extension_options_guest.cc

Issue 2882513005: Propagate opener to BackgroundsContents. (Closed)

Patch Set: Added (and re-enabled) tests. Suppressed opener propagation in one case. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/page_load_metrics/metrics_web_contents_observer.cc ('K') | « extensions/browser/guest_view/extension_options/extension_options_guest.h ('k') | ui/keyboard/content/keyboard_ui_content.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/extension_options/extension_options_guest.cc

diff --git a/extensions/browser/guest_view/extension_options/extension_options_guest.cc b/extensions/browser/guest_view/extension_options/extension_options_guest.cc

index 38c4da351290b5caac0732548c35693cfb54a941..9293b789f983a04b94d740cffefb1c10d1551b65 100644

--- a/extensions/browser/guest_view/extension_options/extension_options_guest.cc

+++ b/extensions/browser/guest_view/extension_options/extension_options_guest.cc

@@ -190,6 +190,7 @@ bool ExtensionOptionsGuest::HandleContextMenu(

bool ExtensionOptionsGuest::ShouldCreateWebContents(

content::WebContents* web_contents,

+ content::RenderFrameHost* opener,

content::SiteInstance* source_site_instance,

int32_t route_id,

int32_t main_frame_route_id,