components/offline_pages/content/background_loader/background_loader_contents_unittest.cc - Issue 2882513005: Propagate opener to BackgroundsContents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/content/background_loader/background_loader_contents_unittest.cc

Issue 2882513005: Propagate opener to BackgroundsContents. (Closed)

Patch Set: Added (and re-enabled) tests. Suppressed opener propagation in one case. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/page_load_metrics/metrics_web_contents_observer.cc ('K') | « components/offline_pages/content/background_loader/background_loader_contents.cc ('k') | components/web_contents_delegate_android/web_contents_delegate_android.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/content/background_loader/background_loader_contents_unittest.cc

diff --git a/components/offline_pages/content/background_loader/background_loader_contents_unittest.cc b/components/offline_pages/content/background_loader/background_loader_contents_unittest.cc

index 3a31cce519025db801b04ed56ba2ec410071fa63..3cfae2c2bc1024d2a548b0ca63fb3ab196f1c7ce 100644

--- a/components/offline_pages/content/background_loader/background_loader_contents_unittest.cc

+++ b/components/offline_pages/content/background_loader/background_loader_contents_unittest.cc

@@ -96,9 +96,9 @@ TEST_F(BackgroundLoaderContentsTest, CannotDownload) {

TEST_F(BackgroundLoaderContentsTest, ShouldNotCreateWebContents) {

ASSERT_FALSE(contents()->ShouldCreateWebContents(

- nullptr /* contents */, nullptr /* source_site_instance */,

- 0 /* route_id */, 0 /* main_frame_route_id */,

- 0 /* main_frame_widget_route_id */,

+ nullptr /* contents */, nullptr /* opener */,

+ nullptr /* source_site_instance */, 0 /* route_id */,

+ 0 /* main_frame_route_id */, 0 /* main_frame_widget_route_id */,

content::mojom::WindowContainerType::NORMAL /* window_container_type */,

GURL() /* opener_url */, "foo" /* frame_name */,

GURL::EmptyGURL() /* target_url */, "bar" /* partition_id */,