components/offline_pages/content/background_loader/background_loader_contents.h - Issue 2882513005: Propagate opener to BackgroundsContents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/content/background_loader/background_loader_contents.h

Issue 2882513005: Propagate opener to BackgroundsContents. (Closed)

Patch Set: Added (and re-enabled) tests. Suppressed opener propagation in one case. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/page_load_metrics/metrics_web_contents_observer.cc ('K') | « chrome/browser/ui/browser.cc ('k') | components/offline_pages/content/background_loader/background_loader_contents.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/content/background_loader/background_loader_contents.h

diff --git a/components/offline_pages/content/background_loader/background_loader_contents.h b/components/offline_pages/content/background_loader/background_loader_contents.h

index a8ba09d45e046768fd99af928ff3a4406729308f..f4c9acda810888b7d92878450768f8ae8e1533b5 100644

--- a/components/offline_pages/content/background_loader/background_loader_contents.h

+++ b/components/offline_pages/content/background_loader/background_loader_contents.h

@@ -45,6 +45,7 @@ class BackgroundLoaderContents : public content::WebContentsDelegate {

bool ShouldCreateWebContents(

content::WebContents* web_contents,

+ content::RenderFrameHost* opener,

content::SiteInstance* source_site_instance,

int32_t route_id,

int32_t main_frame_route_id,