chrome/browser/content_settings/mixed_content_settings_tab_helper.cc - Issue 2882513005: Propagate opener to BackgroundsContents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/content_settings/mixed_content_settings_tab_helper.cc

Issue 2882513005: Propagate opener to BackgroundsContents. (Closed)

Patch Set: Tweaked the comment in DriveWebContentsManager::ShouldCreateWebContents Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/first_run/drive_first_run_controller.cc ('k') | chrome/browser/extensions/api/tab_capture/offscreen_tab.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/content_settings/mixed_content_settings_tab_helper.cc

diff --git a/chrome/browser/content_settings/mixed_content_settings_tab_helper.cc b/chrome/browser/content_settings/mixed_content_settings_tab_helper.cc

index 0a6e6ff3da0beb642d060997750176e02e456a6e..a6c8e9c2b7ce238411dbe0a4ac01d043279062cd 100644

--- a/chrome/browser/content_settings/mixed_content_settings_tab_helper.cc

+++ b/chrome/browser/content_settings/mixed_content_settings_tab_helper.cc

@@ -23,7 +23,8 @@ MixedContentSettingsTabHelper::MixedContentSettingsTabHelper(WebContents* tab)

// because in Chrome these settings are maintained at the tab level instead of

// at the frame level as Blink does.

MixedContentSettingsTabHelper* opener_settings =

- MixedContentSettingsTabHelper::FromWebContents(tab->GetOpener());

+ MixedContentSettingsTabHelper::FromWebContents(

+ WebContents::FromRenderFrameHost(tab->GetOpener()));

if (opener_settings) {

insecure_content_site_instance_ =

opener_settings->insecure_content_site_instance_;