Propagate opener to BackgroundsContents.

chrome/browser/chromeos/first_run/drive_first_run_controller.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/first_run/drive_first_run_controller.h"
 
 #include <stdint.h>
 #include <utility>
 
 #include "ash/shell.h"
@@ skipping 145 matching lines @@
 
   void DidFailLoad(content::RenderFrameHost* render_frame_host,
                    const GURL& validated_url,
                    int error_code,
                    const base::string16& error_description,
                    bool was_ignored_by_handler) override;
 
   // content::WebContentsDelegate overrides:
   bool ShouldCreateWebContents(
       content::WebContents* web_contents,
+      content::RenderFrameHost* opener,
       content::SiteInstance* source_site_instance,
       int32_t route_id,
       int32_t main_frame_route_id,
       int32_t main_frame_widget_route_id,
       content::mojom::WindowContainerType window_container_type,
       const GURL& opener_url,
       const std::string& frame_name,
       const GURL& target_url,
       const std::string& partition_id,
       content::SessionStorageNamespace* session_storage_namespace) override;
@@ skipping 93 matching lines @@
     bool was_ignored_by_handler) {
   if (!render_frame_host->GetParent()) {
     LOG(WARNING) << "Failed to load WebContents to enable offline mode.";
     OnOfflineInit(false,
                   DriveFirstRunController::OUTCOME_WEB_CONTENTS_LOAD_FAILED);
   }
 }
 
 bool DriveWebContentsManager::ShouldCreateWebContents(
     content::WebContents* web_contents,
+    content::RenderFrameHost* opener,
     content::SiteInstance* source_site_instance,
     int32_t route_id,
     int32_t main_frame_route_id,
     int32_t main_frame_widget_route_id,
     content::mojom::WindowContainerType window_container_type,
     const GURL& opener_url,
     const std::string& frame_name,
     const GURL& target_url,
     const std::string& partition_id,
     content::SessionStorageNamespace* session_storage_namespace) {
@@ skipping 14 matching lines @@
 
   // Prevent redirection if background contents already exists.
   if (background_contents_service->GetAppBackgroundContents(
       base::UTF8ToUTF16(app_id_))) {
     return false;
   }
   // We are creating a new SiteInstance (and thus a new renderer process) here,
   // so we must not use |route_id|, etc, which are IDs in a different process.
   BackgroundContents* contents =
       background_contents_service->CreateBackgroundContents(
-          content::SiteInstance::Create(profile_), MSG_ROUTING_NONE,
+          content::SiteInstance::Create(profile_), nullptr, MSG_ROUTING_NONE,

[Andrew T Wilson (Slow), 2017/06/05 08:32:46]

I'm not sure why we are passing in nullptr here instead of opener - maybe this
is worth a comment?

[Łukasz Anforowicz, 2017/06/05 16:57:56]

Good point - this is not that obvious what is going on here.  If you look at
Browser::MaybeCreateBackgroundContents, then it has 2 calls to
CreateBackgroundContents - one where the opener is propagated, and one where no
opener is propagated (and where MSG_ROUTING_NONE are passed, because [since
we're not establishing an opener relationship] we don't care to create the new
contents in the same renderer process as the opener).  Here we also need the
second case, because (just like the second case in
Browser::MaybeCreateBackgroundContents) here also we have allow_js_access:false
(i.e. see chrome/test/data/drive_first_run/app/manifest.json) that corresponds
to the MSG_ROUTING_NONE usage.

I've added a comment.

           MSG_ROUTING_NONE, MSG_ROUTING_NONE, profile_, frame_name,
           base::ASCIIToUTF16(app_id_), partition_id, session_storage_namespace);
 
   contents->web_contents()->GetController().LoadURL(
       target_url,
       content::Referrer(),
       ui::PAGE_TRANSITION_LINK,
       std::string());
 
   // Return false as we already created the WebContents here.
@@ skipping 145 matching lines @@
           base::UTF8ToUTF16(extension->name()), GURL(),
           message_center::NotifierId(message_center::NotifierId::APPLICATION,
                                      kDriveHostedAppId),
           data, new DriveOfflineNotificationDelegate(profile_)));
   notification->set_priority(message_center::LOW_PRIORITY);
   message_center::MessageCenter::Get()->AddNotification(
       std::move(notification));
 }
 
 }  // namespace chromeos