Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Side by Side Diff: chrome/browser/ui/browser.h

Issue 2882513005: Propagate opener to BackgroundsContents. (Closed)
Patch Set: Tweaked the comment in DriveWebContentsManager::ShouldCreateWebContents Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_BROWSER_H_ 5 #ifndef CHROME_BROWSER_UI_BROWSER_H_
6 #define CHROME_BROWSER_UI_BROWSER_H_ 6 #define CHROME_BROWSER_UI_BROWSER_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <map> 10 #include <map>
(...skipping 602 matching lines...) Expand 10 before | Expand all | Expand 10 after
613 bool* proceed_to_fire_unload) override; 613 bool* proceed_to_fire_unload) override;
614 bool ShouldFocusLocationBarByDefault(content::WebContents* source) override; 614 bool ShouldFocusLocationBarByDefault(content::WebContents* source) override;
615 void ViewSourceForTab(content::WebContents* source, 615 void ViewSourceForTab(content::WebContents* source,
616 const GURL& page_url) override; 616 const GURL& page_url) override;
617 void ViewSourceForFrame(content::WebContents* source, 617 void ViewSourceForFrame(content::WebContents* source,
618 const GURL& frame_url, 618 const GURL& frame_url,
619 const content::PageState& frame_page_state) override; 619 const content::PageState& frame_page_state) override;
620 void ShowRepostFormWarningDialog(content::WebContents* source) override; 620 void ShowRepostFormWarningDialog(content::WebContents* source) override;
621 bool ShouldCreateWebContents( 621 bool ShouldCreateWebContents(
622 content::WebContents* web_contents, 622 content::WebContents* web_contents,
623 content::RenderFrameHost* opener,
623 content::SiteInstance* source_site_instance, 624 content::SiteInstance* source_site_instance,
624 int32_t route_id, 625 int32_t route_id,
625 int32_t main_frame_route_id, 626 int32_t main_frame_route_id,
626 int32_t main_frame_widget_route_id, 627 int32_t main_frame_widget_route_id,
627 content::mojom::WindowContainerType window_container_type, 628 content::mojom::WindowContainerType window_container_type,
628 const GURL& opener_url, 629 const GURL& opener_url,
629 const std::string& frame_name, 630 const std::string& frame_name,
630 const GURL& target_url, 631 const GURL& target_url,
631 const std::string& partition_id, 632 const std::string& partition_id,
632 content::SessionStorageNamespace* session_storage_namespace) override; 633 content::SessionStorageNamespace* session_storage_namespace) override;
(...skipping 213 matching lines...) Expand 10 before | Expand all | Expand 10 after
846 bool ShouldHideUIForFullscreen() const; 847 bool ShouldHideUIForFullscreen() const;
847 848
848 // Returns true if we can start the shutdown sequence for the browser, i.e. 849 // Returns true if we can start the shutdown sequence for the browser, i.e.
849 // the last browser window is being closed. 850 // the last browser window is being closed.
850 bool ShouldStartShutdown() const; 851 bool ShouldStartShutdown() const;
851 852
852 // Creates a BackgroundContents if appropriate; return true if one was 853 // Creates a BackgroundContents if appropriate; return true if one was
853 // created. 854 // created.
854 bool MaybeCreateBackgroundContents( 855 bool MaybeCreateBackgroundContents(
855 content::SiteInstance* source_site_instance, 856 content::SiteInstance* source_site_instance,
857 content::RenderFrameHost* opener,
856 const GURL& opener_url, 858 const GURL& opener_url,
857 int32_t route_id, 859 int32_t route_id,
858 int32_t main_frame_route_id, 860 int32_t main_frame_route_id,
859 int32_t main_frame_widget_route_id, 861 int32_t main_frame_widget_route_id,
860 const std::string& frame_name, 862 const std::string& frame_name,
861 const GURL& target_url, 863 const GURL& target_url,
862 const std::string& partition_id, 864 const std::string& partition_id,
863 content::SessionStorageNamespace* session_storage_namespace); 865 content::SessionStorageNamespace* session_storage_namespace);
864 866
865 // Data members ///////////////////////////////////////////////////////////// 867 // Data members /////////////////////////////////////////////////////////////
(...skipping 143 matching lines...) Expand 10 before | Expand all | Expand 10 after
1009 // The following factory is used for chrome update coalescing. 1011 // The following factory is used for chrome update coalescing.
1010 base::WeakPtrFactory<Browser> chrome_updater_factory_; 1012 base::WeakPtrFactory<Browser> chrome_updater_factory_;
1011 1013
1012 // The following factory is used to close the frame at a later time. 1014 // The following factory is used to close the frame at a later time.
1013 base::WeakPtrFactory<Browser> weak_factory_; 1015 base::WeakPtrFactory<Browser> weak_factory_;
1014 1016
1015 DISALLOW_COPY_AND_ASSIGN(Browser); 1017 DISALLOW_COPY_AND_ASSIGN(Browser);
1016 }; 1018 };
1017 1019
1018 #endif // CHROME_BROWSER_UI_BROWSER_H_ 1020 #endif // CHROME_BROWSER_UI_BROWSER_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/blocked_content/app_modal_dialog_helper.cc ('k') | chrome/browser/ui/browser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698