Propagate opener to BackgroundsContents.

chrome/browser/extensions/app_background_page_apitest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/location.h"
 #include "base/path_service.h"
 #include "base/single_thread_task_runner.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/threading/thread_restrictions.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "build/build_config.h"
 #include "chrome/browser/background/background_contents_service.h"
 #include "chrome/browser/background/background_contents_service_factory.h"
 #include "chrome/browser/background/background_mode_manager.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/extensions/extension_apitest.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_dialogs.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/extensions/application_launch.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/chrome_switches.h"
 #include "content/public/browser/notification_service.h"
+#include "content/public/browser/render_frame_host.h"
+#include "content/public/test/browser_test_utils.h"
 #include "content/public/test/test_notification_tracker.h"
 #include "content/public/test/test_utils.h"
 #include "extensions/browser/process_manager.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/switches.h"
 #include "extensions/test/extension_test_message_listener.h"
 #include "net/dns/mock_host_resolver.h"
 #include "net/test/embedded_test_server/embedded_test_server.h"
+#include "url/gurl.h"
 
 #if !defined(DISABLE_NACL)
 #include "components/nacl/browser/nacl_process_host.h"
 #endif
 
 #if defined(OS_MACOSX)
 #include "base/mac/scoped_nsautorelease_pool.h"
 #endif
 
 using base::ASCIIToUTF16;
@@ skipping 192 matching lines @@
 
   base::FilePath app_dir;
   ASSERT_TRUE(CreateApp(app_manifest, &app_dir));
   // Background mode should not be active now because no background app was
   // loaded.
   ASSERT_TRUE(LoadExtension(app_dir));
   // Background mode be active now because a background page was created when
   // the app was loaded.
   ASSERT_TRUE(WaitForBackgroundMode(true));
 
+  // Verify that the background contents exist.
   const Extension* extension = GetSingleLoadedExtension();
-  ASSERT_TRUE(
-      BackgroundContentsServiceFactory::GetForProfile(browser()->profile())->
-          GetAppBackgroundContents(ASCIIToUTF16(extension->id())));
+  BackgroundContents* background_contents =
+      BackgroundContentsServiceFactory::GetForProfile(browser()->profile())
+          ->GetAppBackgroundContents(ASCIIToUTF16(extension->id()));
+  ASSERT_TRUE(background_contents);
+
+  // Verify that window.opener in the background contents is not set when
+  // creating the background page through the manifest (not through
+  // window.open).
+  EXPECT_FALSE(background_contents->web_contents()->GetOpener());
+  bool window_opener_null_in_js;
+  EXPECT_TRUE(content::ExecuteScriptAndExtractBool(
+      background_contents->web_contents(),
+      "domAutomationController.send(window.opener == null);",
+      &window_opener_null_in_js));
+  EXPECT_TRUE(window_opener_null_in_js);
+
   UnloadExtension(extension->id());
 }
 
 IN_PROC_BROWSER_TEST_F(AppBackgroundPageApiTest, NoJsBackgroundPage) {
   // Keep the task manager up through this test to verify that a crash doesn't
   // happen when window.open creates a background page that switches
   // RenderViewHosts. See http://crbug.com/165138.
   chrome::ShowTaskManager(browser());
 
   // Make sure that no BackgroundContentses get deleted (a signal that repeated
@@ skipping 27 matching lines @@
   ASSERT_TRUE(LoadExtension(app_dir));
 
   // There isn't a background page loaded initially.
   const Extension* extension = GetSingleLoadedExtension();
   ASSERT_FALSE(
       BackgroundContentsServiceFactory::GetForProfile(browser()->profile())->
           GetAppBackgroundContents(ASCIIToUTF16(extension->id())));
   // The test makes sure that window.open returns null.
   ASSERT_TRUE(RunExtensionTest("app_background_page/no_js")) << message_;
   // And after it runs there should be a background page.
-  ASSERT_TRUE(
-      BackgroundContentsServiceFactory::GetForProfile(browser()->profile())->
-          GetAppBackgroundContents(ASCIIToUTF16(extension->id())));
+  BackgroundContents* background_contents =
+      BackgroundContentsServiceFactory::GetForProfile(browser()->profile())
+          ->GetAppBackgroundContents(ASCIIToUTF16(extension->id()));
+  ASSERT_TRUE(background_contents);
+
+  // Verify that window.opener in the background contents is not set when
+  // allow_js_access=false.
+  EXPECT_FALSE(background_contents->web_contents()->GetOpener());
+  bool window_opener_null_in_js;
+  EXPECT_TRUE(content::ExecuteScriptAndExtractBool(
+      background_contents->web_contents(),
+      "domAutomationController.send(window.opener == null);",
+      &window_opener_null_in_js));
+  EXPECT_TRUE(window_opener_null_in_js);
 
   EXPECT_EQ(0u, background_deleted_tracker.size());
   UnloadExtension(extension->id());
 }
 
 IN_PROC_BROWSER_TEST_F(AppBackgroundPageApiTest, NoJsManifestBackgroundPage) {
   std::string app_manifest = base::StringPrintf(
       "{"
       "  \"name\": \"App\","
       "  \"version\": \"0.1\","
@@ skipping 12 matching lines @@
       "    \"allow_js_access\": false"
       "  }"
       "}",
       embedded_test_server()->port(),
       embedded_test_server()->port());
 
   base::FilePath app_dir;
   ASSERT_TRUE(CreateApp(app_manifest, &app_dir));
   ASSERT_TRUE(LoadExtension(app_dir));
 
-  // The background page should load, but window.open should return null.
+  // The background page should load.
   const Extension* extension = GetSingleLoadedExtension();
-  ASSERT_TRUE(
-      BackgroundContentsServiceFactory::GetForProfile(browser()->profile())->
-          GetAppBackgroundContents(ASCIIToUTF16(extension->id())));
+  BackgroundContents* background_contents =
+      BackgroundContentsServiceFactory::GetForProfile(browser()->profile())
+          ->GetAppBackgroundContents(ASCIIToUTF16(extension->id()));
+  ASSERT_TRUE(background_contents);
+
+  // Verify that window.opener in the background contents is not set when
+  // creating the background page through the manifest (not through
+  // window.open).
+  EXPECT_FALSE(background_contents->web_contents()->GetOpener());
+  bool window_opener_null_in_js;
+  EXPECT_TRUE(content::ExecuteScriptAndExtractBool(
+      background_contents->web_contents(),
+      "domAutomationController.send(window.opener == null);",
+      &window_opener_null_in_js));
+  EXPECT_TRUE(window_opener_null_in_js);
+
+  // window.open should return null.
   ASSERT_TRUE(RunExtensionTest("app_background_page/no_js_manifest")) <<
       message_;
+
+  // Verify that window.opener in the background contents is still not set.
+  EXPECT_FALSE(background_contents->web_contents()->GetOpener());
+  EXPECT_TRUE(content::ExecuteScriptAndExtractBool(
+      background_contents->web_contents(),
+      "domAutomationController.send(window.opener == null);",
+      &window_opener_null_in_js));
+  EXPECT_TRUE(window_opener_null_in_js);
+
   UnloadExtension(extension->id());
 }
 
 IN_PROC_BROWSER_TEST_F(AppBackgroundPageApiTest, OpenTwoBackgroundPages) {
   std::string app_manifest = base::StringPrintf(
       "{"
       "  \"name\": \"App\","
       "  \"version\": \"0.1\","
       "  \"manifest_version\": 2,"
       "  \"app\": {"
@@ skipping 68 matching lines @@
       "}",
       embedded_test_server()->port(),
       embedded_test_server()->port());
 
   base::FilePath app_dir;
   ASSERT_TRUE(CreateApp(app_manifest, &app_dir));
   ASSERT_TRUE(LoadExtension(app_dir));
   ASSERT_TRUE(RunExtensionTest("app_background_page/bg_open")) << message_;
 }
 
-IN_PROC_BROWSER_TEST_F(AppBackgroundPageApiTest, DISABLED_OpenThenClose) {
+IN_PROC_BROWSER_TEST_F(AppBackgroundPageApiTest, OpenThenClose) {
   std::string app_manifest = base::StringPrintf(
       "{"
       "  \"name\": \"App\","
       "  \"version\": \"0.1\","
       "  \"manifest_version\": 2,"
       "  \"app\": {"
       "    \"urls\": ["
       "      \"http://a.com/\""
       "    ],"
       "    \"launch\": {"
@@ skipping 10 matching lines @@
   // There isn't a background page loaded initially.
   const Extension* extension = GetSingleLoadedExtension();
   ASSERT_FALSE(
       BackgroundContentsServiceFactory::GetForProfile(browser()->profile())->
           GetAppBackgroundContents(ASCIIToUTF16(extension->id())));
   // Background mode should not be active until a background page is created.
   ASSERT_TRUE(WaitForBackgroundMode(false));
   ASSERT_TRUE(RunExtensionTest("app_background_page/basic_open")) << message_;
   // Background mode should be active now because a background page was created.
   ASSERT_TRUE(WaitForBackgroundMode(true));
-  ASSERT_TRUE(
-      BackgroundContentsServiceFactory::GetForProfile(browser()->profile())->
-          GetAppBackgroundContents(ASCIIToUTF16(extension->id())));
+
+  // Verify that the background contents exist.
+  BackgroundContents* background_contents =
+      BackgroundContentsServiceFactory::GetForProfile(browser()->profile())
+          ->GetAppBackgroundContents(ASCIIToUTF16(extension->id()));
+  ASSERT_TRUE(background_contents);
+
+  // Verify that window.opener in the background contents is set.
+  content::RenderFrameHost* background_opener =
+      background_contents->web_contents()->GetOpener();
+  ASSERT_TRUE(background_opener);
+  std::string window_opener_href;
+  EXPECT_TRUE(content::ExecuteScriptAndExtractString(
+      background_contents->web_contents(),
+      "domAutomationController.send(window.opener.location.href);",
+      &window_opener_href));
+  EXPECT_EQ(window_opener_href,
+            background_opener->GetLastCommittedURL().spec());
+
   // Now close the BackgroundContents.
   ASSERT_TRUE(RunExtensionTest("app_background_page/basic_close")) << message_;
+
   // Background mode should no longer be active.
   ASSERT_TRUE(WaitForBackgroundMode(false));
   ASSERT_FALSE(
       BackgroundContentsServiceFactory::GetForProfile(browser()->profile())->
           GetAppBackgroundContents(ASCIIToUTF16(extension->id())));
 }
 
 IN_PROC_BROWSER_TEST_F(AppBackgroundPageApiTest, UnloadExtensionWhileHidden) {
   std::string app_manifest = base::StringPrintf(
       "{"
@@ skipping 94 matching lines @@
   ExtensionTestMessageListener ready_listener("ready", true);
   LaunchTestingApp();
   EXPECT_TRUE(ready_listener.WaitUntilSatisfied());
 
   ExtensionTestMessageListener created_listener("created_module:1", false);
   ready_listener.Reply("create_module_without_hack");
   EXPECT_TRUE(created_listener.WaitUntilSatisfied());
 }
 
 #endif  //  !defined(DISABLE_NACL)