[Merge to M59] MD WebUI: Fix Action/Cancel button padding in MD History/Bookmarks

[Merge to M59] MD WebUI: Fix Action/Cancel button padding in MD History/Bookmarks

This fixes an issue where action/cancel buttons in MD History/Bookmarks
(and possibly other pages) had no vertical padding, after the default
paper-button padding was disabled in crrev.com/466545.

BUG=703998
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2837763002
Cr-Commit-Position: refs/heads/master@{#467238}
Committed: https://chromium.googlesource.com/chromium/src/+/b546eb97eb9f5c8683f0560a625208d5217a3d16

patch from issue 2837763002 at patchset 20001 (http://crrev.com/2837763002#ps20001)

[Merge to M59] md-settings: Tweak padding for action/cancel buttons and subpage header.

Add left right padding to action/cancel buttons.
Reduce bottom padding for settings subpage header.
Also removed a todo for button opacity(saw a new value in specs).

Link to specs in the bug.

TEST=manual
BUG=703998
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2831963004
Cr-Commit-Position: refs/heads/master@{#466545}
Committed: https://chromium.googlesource.com/chromium/src/+/32d9f5075ba7f767d2c6c6d41794dc70b5ff7bf3

patch from issue 2831963004 at patchset 1 (http://crrev.com/2831963004#ps1)

[sammiequon, 2017-05-11 18:07:35]

The CQ bit was checked by sammiequon@chromium.org

[commit-bot: I haz the power, 2017-05-11 18:08:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 18:08:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 18:08:48]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[sammiequon, 2017-05-11 18:10:02]

Description was changed from

==========
[Merge to M59] MD WebUI: Fix Action/Cancel button padding in MD
History/Bookmarks

This fixes an issue where action/cancel buttons in MD History/Bookmarks
(and possibly other pages) had no vertical padding, after the default
paper-button padding was disabled in crrev.com/466545.

BUG=703998
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2837763002
Cr-Commit-Position: refs/heads/master@{#467238}
Committed:
https://chromium.googlesource.com/chromium/src/+/b546eb97eb9f5c8683f0560a6252...

patch from issue 2837763002 at patchset 20001
(http://crrev.com/2837763002#ps20001)

[Merge to M59] md-settings: Tweak padding for action/cancel buttons and subpage
header.

Add left right padding to action/cancel buttons.
Reduce bottom padding for settings subpage header.
Also removed a todo for button opacity(saw a new value in specs).

Link to specs in the bug.

TEST=manual
BUG=703998
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2831963004
Cr-Commit-Position: refs/heads/master@{#466545}
Committed:
https://chromium.googlesource.com/chromium/src/+/32d9f5075ba7f767d2c6c6d41794...

patch from issue 2831963004 at patchset 1 (http://crrev.com/2831963004#ps1)
==========

to

==========
[Merge to M59] MD WebUI: Fix Action/Cancel button padding in MD
History/Bookmarks

This fixes an issue where action/cancel buttons in MD History/Bookmarks
(and possibly other pages) had no vertical padding, after the default
paper-button padding was disabled in crrev.com/466545.

BUG=703998
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2837763002
Cr-Commit-Position: refs/heads/master@{#467238}
Committed:
https://chromium.googlesource.com/chromium/src/+/b546eb97eb9f5c8683f0560a6252...

patch from issue 2837763002 at patchset 20001
(http://crrev.com/2837763002#ps20001)

[Merge to M59] md-settings: Tweak padding for action/cancel buttons and subpage
header.

Add left right padding to action/cancel buttons.
Reduce bottom padding for settings subpage header.
Also removed a todo for button opacity(saw a new value in specs).

Link to specs in the bug.

TEST=manual
BUG=703998
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2831963004
Cr-Commit-Position: refs/heads/master@{#466545}
Committed:
https://chromium.googlesource.com/chromium/src/+/32d9f5075ba7f767d2c6c6d41794...

patch from issue 2831963004 at patchset 1 (http://crrev.com/2831963004#ps1)
==========

[sammiequon, 2017-05-11 18:10:02]

sammiequon@chromium.org changed reviewers:
+ stevenjb@chromium.org

[sammiequon, 2017-05-11 18:11:11]

On 2017/05/11 18:08:48, commit-bot: I haz the power wrote:
> No L-G-T-M from a valid reviewer yet.
> CQ run can only be started once the patch has received an L-G-T-M from a full
> committer.
> Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
> full super star committer.
> Committers are members of the group "project-chromium-committers".
> Note that this has nothing to do with OWNERS files.

stevenjb@ - Please take a look.

This merges https://codereview.chromium.org/2831963004 and the follow up
https://codereview.chromium.org/2837763002 because the first one broke some
stuff in history/bookmarks.

Thanks!

[stevenjb, 2017-05-11 18:28:45]

stevenjb@chromium.org changed reviewers:
+ dbeam@chromium.org

[stevenjb, 2017-05-11 18:28:45]

This lgtm. +dbeam@ to confirm that we are OK merging this to 59 at this point.

[Dan Beam, 2017-05-16 01:54:59]

not lgtm i need screenshots and a really good reason

[sammiequon, 2017-05-16 02:03:09]

On 2017/05/16 01:54:59, Dan Beam wrote:
> not lgtm i need screenshots and a really good reason

Ok, I'll check with the PM tomorrow and then give screenshots and a reason if he
still wants it, but the original CLs on master are still OK?

[sammiequon, 2017-05-17 00:47:54]

On 2017/05/16 02:03:09, sammiequon wrote:
> On 2017/05/16 01:54:59, Dan Beam wrote:
> > not lgtm i need screenshots and a really good reason
> 
> Ok, I'll check with the PM tomorrow and then give screenshots and a reason if
he
> still wants it, but the original CLs on master are still OK?

We don't have a really good reason to merge so closing.