Chromium Code Reviews

Issue 288233002: Ensure that collection iterators' maps have constructors (Closed)

Created:
6 years, 7 months ago by Jakob Kummerow
Modified:
6 years, 7 months ago
Reviewers:
arv (Not doing code reviews), rossberg
CC:
v8-dev, rafaelw, arv (Not doing code reviews)
Visibility:
Public.

Description

Ensure that collection iterators' maps have constructors This fixes JSObject::GetCreationContext() for such iterators. R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21333

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+2 lines, -0 lines)
M src/bootstrapper.cc View 1 chunk +2 lines, -0 lines 0 comments

Messages

Total messages: 8 (0 generated)
Jakob Kummerow
Andreas: PTAL. Adam, Rafael: FYI. It's unclear whether there are any other objects violating the ...
6 years, 7 months ago (2014-05-15 13:43:26 UTC) #1
Jakob Kummerow
+arv FYI, who implemented JS{Map,Set}Iterator
6 years, 7 months ago (2014-05-15 13:46:40 UTC) #2
rossberg
lgtm LGTM. @Rafael: to expand on Jakob mentioned is that GetCreationContext
6 years, 7 months ago (2014-05-15 13:53:36 UTC) #3
rossberg
On 2014/05/15 13:53:36, rossberg wrote: > lgtm > > LGTM. > > @Rafael: to expand ...
6 years, 7 months ago (2014-05-15 14:02:44 UTC) #4
Jakob Kummerow
Committed patchset #1 manually as r21333 (presubmit successful).
6 years, 7 months ago (2014-05-15 14:14:05 UTC) #5
arv (Not doing code reviews)
As long as .constructor does not exist on the __proto__ object this is fine. I ...
6 years, 7 months ago (2014-05-15 21:36:13 UTC) #6
adamk
On 2014/05/15 14:02:44, rossberg wrote: > On 2014/05/15 13:53:36, rossberg wrote: > > lgtm > ...
6 years, 7 months ago (2014-05-16 09:00:05 UTC) #7
rossberg
6 years, 7 months ago (2014-05-16 09:09:26 UTC) #8
Message was sent while issue was closed.
@arv, yes, .constructor is independent of map()->constructor(). The latter
should not be observable externally.

@adamk, ah, thanks for pointing out. We still probably need to investigate this.
I'll discuss with Toon when he is back.

Powered by Google App Engine