tests/compiler/dart2js/mirrors_used_test.dart - Issue 28823004: mark barback test "too_many_open_files_test" as flaky

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/compiler/dart2js/mirrors_used_test.dart

Issue 28823004: mark barback test "too_many_open_files_test" as flaky (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tests/compiler/dart2js/deferred_load_graph_segmentation_test.dart ('k') | tests/compiler/dart2js/simple_inferrer_callers_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tests/compiler/dart2js/mirrors_used_test.dart

diff --git a/tests/compiler/dart2js/mirrors_used_test.dart b/tests/compiler/dart2js/mirrors_used_test.dart

index 9d550f5feae321805f92d957bbc024fd834c1eb9..eed4542c10f28b6e1d5dd33697f89874a4b3aefe 100644

--- a/tests/compiler/dart2js/mirrors_used_test.dart

+++ b/tests/compiler/dart2js/mirrors_used_test.dart

@@ -79,8 +79,7 @@ void main() {

for (var library in compiler.libraries.values) {

library.forEachLocalMember((member) {

- if (library == compiler.mainApp

- && member.name == 'Foo') {

+ if (library == compiler.mainApp && member.name == 'Foo') {

Expect.isTrue(

compiler.backend.isNeededForReflection(member), '$member');

member.forEachLocalMember((classMember) {