Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp

Issue 2882193002: [devtools] Add DOMSnapshot domain for dom+layout+style snapshots. (Closed)
Patch Set: back to DOMSnapshot domain, with custom node types + traversal. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
diff --git a/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
index cf9f2c9a217574bdeaf83672cfb8b987bd4b4e8d..a0803c8d3ef9754cd1cbb2e6aa23dc6e03139bb5 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
+++ b/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
@@ -476,7 +476,7 @@ Response InspectorDOMAgent::getFlattenedDocument(
Maybe<bool> pierce,
std::unique_ptr<protocol::Array<protocol::DOM::Node>>* nodes) {
if (!Enabled())
- return Response::Error("Document not enabled");
+ return Response::Error("DOM agent hasn't been enabled");
if (!document_)
return Response::Error("Document is not available");
@@ -1329,7 +1329,8 @@ String InspectorDOMAgent::DocumentURLString(Document* document) {
return document->Url().GetString();
}
-static String DocumentBaseURLString(Document* document) {
+// static
+String InspectorDOMAgent::DocumentBaseURLString(Document* document) {
return document->BaseURLForOverride(document->BaseURL()).GetString();
}

Powered by Google App Engine
This is Rietveld 408576698