Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Unified Diff: content/browser/devtools/protocol/schema_handler.cc

Issue 2882193002: [devtools] Add DOMSnapshot domain for dom+layout+style snapshots. (Closed)
Patch Set: back to DOMSnapshot domain, with custom node types + traversal. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/protocol/schema_handler.cc
diff --git a/content/browser/devtools/protocol/schema_handler.cc b/content/browser/devtools/protocol/schema_handler.cc
index f4f862cb7c23c3e40d8c31518dd7cd9c60fea2de..30b45e3324cb07828927a0d9f2b2456efc16c72e 100644
--- a/content/browser/devtools/protocol/schema_handler.cc
+++ b/content/browser/devtools/protocol/schema_handler.cc
@@ -22,37 +22,15 @@ Response SchemaHandler::GetDomains(
std::unique_ptr<protocol::Array<Schema::Domain>>* domains) {
// TODO(kozyatisnkiy): get this from the target instead of hardcoding a list.
static const char kVersion[] = "1.2";
- static const char* kDomains[] = {"Inspector",
- "Memory",
- "Page",
- "Emulation",
- "Security",
- "Network",
- "Database",
- "IndexedDB",
- "CacheStorage",
- "DOMStorage",
- "CSS",
- "ApplicationCache",
- "DOM",
- "IO",
- "DOMDebugger",
- "ServiceWorker",
- "Input",
- "LayerTree",
- "DeviceOrientation",
- "Tracing",
- "Animation",
- "Accessibility",
- "Storage",
- "Log",
- "Runtime",
- "Debugger",
- "Profiler",
- "HeapProfiler",
- "Schema",
- "Target",
- "Overlay"};
+ static const char* kDomains[] = {
pfeldman 2017/06/06 22:54:29 Wondering if git cl format is cool with this :)
Eric Seckler 2017/06/07 10:23:37 Oh, this was done by "git cl format" (wasn't me :)
+ "Inspector", "Memory", "Page", "Emulation",
+ "Security", "Network", "Database", "IndexedDB",
+ "CacheStorage", "DOMStorage", "CSS", "ApplicationCache",
+ "DOM", "IO", "DOMDebugger", "DOMSnapshot",
+ "ServiceWorker", "Input", "LayerTree", "DeviceOrientation",
+ "Tracing", "Animation", "Accessibility", "Storage",
+ "Log", "Runtime", "Debugger", "Profiler",
+ "HeapProfiler", "Schema", "Target", "Overlay"};
*domains = protocol::Array<Schema::Domain>::create();
for (size_t i = 0; i < arraysize(kDomains); ++i) {
(*domains)->addItem(Schema::Domain::Create()

Powered by Google App Engine
This is Rietveld 408576698