MD Settings: Improve Sync Page Enter key handling.

chrome/browser/resources/settings/people_page/sync_page.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 (function() {
 
 /**
  * Names of the radio buttons which allow the user to choose their encryption
  * mechanism.
  * @enum {string}
@@ skipping 275 matching lines @@
    * @return {boolean} Whether the passphrase save button should be enabled.
    * @private
    */
   isSaveNewPassphraseEnabled_: function(passphrase, confirmation) {
     return passphrase !== '' && confirmation !== '';
   },
 
   /**
    * Sends the newly created custom sync passphrase to the browser.
    * @private
+   * @param {!{target: !{tagName: string},
+   *           type: string,
+   *           key: (string|undefined)}} e

[Dan Beam, 2017/05/16 02:20:55]

KeyboardEvent?

[tommycli, 2017/05/16 16:17:53]

Done. I used Event because it could be a mouse event too.

    */
-  onSaveNewPassphraseTap_: function() {
+  onSaveNewPassphraseTap_: function(e) {
     assert(this.creatingNewPassphrase_);
 
+    // Ignore events on irrevelant elements or with irrelevant keys.
+    if (e.target.tagName != 'PAPER-BUTTON' && e.target.tagName != 'PAPER-INPUT')
+      return;
+    if (e.type == 'keypress' && e.key != 'Enter')
+      return;
+
     // If a new password has been entered but it is invalid, do not send the
     // sync state to the API.
     if (!this.validateCreatedPassphrases_())
       return;
 
     this.syncPrefs.encryptAllData = true;
     this.syncPrefs.setNewPassphrase = true;
     this.syncPrefs.passphrase = this.passphrase_;
 
     this.browserProxy_.setSyncEncryption(this.syncPrefs).then(
         this.handlePageStatusChanged_.bind(this));
   },
 
   /**
    * Sends the user-entered existing password to re-enable sync.
    * @private
+   * @param {Event} e
    */
-  onSubmitExistingPassphraseTap_: function() {
+  onSubmitExistingPassphraseTap_: function(e) {
+    if (e.type == 'keypress' && e.key != 'Enter')
+      return;
+
     assert(!this.creatingNewPassphrase_);
 
     this.syncPrefs.setNewPassphrase = false;
 
     this.syncPrefs.passphrase = this.existingPassphrase_;
     this.existingPassphrase_ = '';
 
     this.browserProxy_.setSyncEncryption(this.syncPrefs).then(
         this.handlePageStatusChanged_.bind(this));
   },
@@ skipping 99 matching lines @@
   onLearnMoreTap_: function(event) {
     if (event.target.tagName == 'A') {
       // Stop the propagation of events, so that clicking on links inside
       // checkboxes or radio buttons won't change the value.
       event.stopPropagation();
     }
   }
 });
 
 })();