Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1261)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 288213002: Refactor MacroAssembler::Prologue. (Closed)

Created:
6 years, 7 months ago by Yang
Modified:
6 years, 7 months ago
Reviewers:
titzer
CC:
v8-dev
Visibility:
Public.

Description

Refactor MacroAssembler::Prologue. R=titzer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21329

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -114 lines) Patch
M src/arm/full-codegen-arm.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/arm/macro-assembler-arm.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +26 lines, -21 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/arm64/macro-assembler-arm64.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 chunk +17 lines, -16 lines 0 comments Download
M src/full-codegen.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +18 lines, -17 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +26 lines, -25 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +16 lines, -15 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
6 years, 7 months ago (2014-05-15 11:53:38 UTC) #1
titzer
LGTM https://codereview.chromium.org/288213002/diff/1/src/ia32/full-codegen-ia32.cc File src/ia32/full-codegen-ia32.cc (right): https://codereview.chromium.org/288213002/diff/1/src/ia32/full-codegen-ia32.cc#newcode160 src/ia32/full-codegen-ia32.cc:160: ASSERT(!info->IsStub()); Move this assert to the constructor of ...
6 years, 7 months ago (2014-05-15 12:00:30 UTC) #2
Yang
https://codereview.chromium.org/288213002/diff/1/src/ia32/full-codegen-ia32.cc File src/ia32/full-codegen-ia32.cc (right): https://codereview.chromium.org/288213002/diff/1/src/ia32/full-codegen-ia32.cc#newcode160 src/ia32/full-codegen-ia32.cc:160: ASSERT(!info->IsStub()); On 2014/05/15 12:00:31, titzer wrote: > Move this ...
6 years, 7 months ago (2014-05-15 12:07:14 UTC) #3
Yang
6 years, 7 months ago (2014-05-15 12:10:16 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 manually as r21329 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698