net/extras/sqlite/sqlite_persistent_cookie_store.cc - Issue 2882063002: Add a SetCanonicalCookie method for CookieMonster.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/extras/sqlite/sqlite_persistent_cookie_store.cc

Issue 2882063002: Add a SetCanonicalCookie method for CookieMonster. (Closed)

Patch Set: Fix try jobs and do some cleanup. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/extras/sqlite/sqlite_persistent_cookie_store.cc

diff --git a/net/extras/sqlite/sqlite_persistent_cookie_store.cc b/net/extras/sqlite/sqlite_persistent_cookie_store.cc

index 83cc469e94d0815811b9bad7d93ca0c62868f195..5228ae3f3fec500a7a7f27e31a949a8a1719906a 100644

--- a/net/extras/sqlite/sqlite_persistent_cookie_store.cc

+++ b/net/extras/sqlite/sqlite_persistent_cookie_store.cc

@@ -832,7 +832,8 @@ void SQLitePersistentCookieStore::Backend::MakeCookiesFromSQLStatement(

static_cast<DBCookiePriority>(smt.ColumnInt(13))))); // priority

DLOG_IF(WARNING, cc->CreationDate() > Time::Now())

<< L"CreationDate too recent";

- cookies->push_back(std::move(cc));

+ if (cc->IsCanonical())

+ cookies->push_back(std::move(cc));

++num_cookies_read_;

}