Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: net/cookies/canonical_cookie_unittest.cc

Issue 2882063002: Add a SetCanonicalCookie method for CookieMonster. (Closed)
Patch Set: Fix try jobs and do some cleanup. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/cookies/canonical_cookie_unittest.cc
diff --git a/net/cookies/canonical_cookie_unittest.cc b/net/cookies/canonical_cookie_unittest.cc
index 402846db30f8de12f427021b36be7a35d4ddd519..89e234b2f2d316c37bb92e4184aa907da43e3be5 100644
--- a/net/cookies/canonical_cookie_unittest.cc
+++ b/net/cookies/canonical_cookie_unittest.cc
@@ -596,6 +596,75 @@ TEST(CanonicalCookieTest, EnforceSecureCookiesRequireSecureScheme) {
EXPECT_TRUE(https_cookie_secure.get());
}
+TEST(CanonicalCookieTest, IsCanonical) {
+ EXPECT_TRUE(CanonicalCookie("A", "B", "x.y", "/path", base::Time(),
+ base::Time(), base::Time(), false, false,
+ CookieSameSite::NO_RESTRICTION,
+ COOKIE_PRIORITY_LOW)
+ .IsCanonical());
+ EXPECT_FALSE(CanonicalCookie("", "B", "x.y", "/path", base::Time(),
+ base::Time(), base::Time(), false, false,
+ CookieSameSite::NO_RESTRICTION,
+ COOKIE_PRIORITY_LOW)
+ .IsCanonical());
+ EXPECT_FALSE(CanonicalCookie("A ", "B", "x.y", "/path", base::Time(),
+ base::Time(), base::Time(), false, false,
+ CookieSameSite::NO_RESTRICTION,
+ COOKIE_PRIORITY_LOW)
+ .IsCanonical());
+ EXPECT_FALSE(CanonicalCookie("A=", "B", "x.y", "/path", base::Time(),
+ base::Time(), base::Time(), false, false,
+ CookieSameSite::NO_RESTRICTION,
+ COOKIE_PRIORITY_LOW)
+ .IsCanonical());
+ EXPECT_FALSE(CanonicalCookie("A", "B;", "x.y", "/path", base::Time(),
+ base::Time(), base::Time(), false, false,
+ CookieSameSite::NO_RESTRICTION,
+ COOKIE_PRIORITY_LOW)
+ .IsCanonical());
+ EXPECT_FALSE(CanonicalCookie("A", "B", ";x.y", "/path", base::Time(),
+ base::Time(), base::Time(), false, false,
+ CookieSameSite::NO_RESTRICTION,
+ COOKIE_PRIORITY_LOW)
+ .IsCanonical());
+ EXPECT_FALSE(CanonicalCookie("A", "B", "x.y ", "/path", base::Time(),
+ base::Time(), base::Time(), false, false,
+ CookieSameSite::NO_RESTRICTION,
+ COOKIE_PRIORITY_LOW)
+ .IsCanonical());
+ EXPECT_FALSE(CanonicalCookie("A", "B", "x.y", "path", base::Time(),
+ base::Time(), base::Time(), false, false,
+ CookieSameSite::NO_RESTRICTION,
+ COOKIE_PRIORITY_LOW)
+ .IsCanonical());
+ EXPECT_FALSE(CanonicalCookie("A", "B", "x.y", "/path ", base::Time(),
+ base::Time(), base::Time(), false, false,
+ CookieSameSite::NO_RESTRICTION,
+ COOKIE_PRIORITY_LOW)
+ .IsCanonical());
+ EXPECT_FALSE(CanonicalCookie("A", "B", "x.y", "/path;", base::Time(),
+ base::Time(), base::Time(), false, false,
+ CookieSameSite::NO_RESTRICTION,
+ COOKIE_PRIORITY_LOW)
+ .IsCanonical());
+ EXPECT_TRUE(CanonicalCookie("A", "B", "x.y", "/path", base::Time(),
+ base::Time(), base::Time(), false, false,
+ CookieSameSite::NO_RESTRICTION,
+ COOKIE_PRIORITY_LOW)
+ .IsCanonical());
+}
+
+TEST(CanonicalCookieTest, TestSetCreationDate) {
+ CanonicalCookie cookie("A", "B", "x.y", "/path", base::Time(), base::Time(),
+ base::Time(), false, false,
+ CookieSameSite::NO_RESTRICTION, COOKIE_PRIORITY_LOW);
+ EXPECT_TRUE(cookie.CreationDate().is_null());
+
+ base::Time now(base::Time::Now());
+ cookie.SetCreationDate(now);
+ EXPECT_EQ(now, cookie.CreationDate());
+}
+
TEST(CanonicalCookieTest, TestPrefixHistograms) {
base::HistogramTester histograms;
const char kCookiePrefixHistogram[] = "Cookie.CookiePrefix";

Powered by Google App Engine
This is Rietveld 408576698