Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTableSection.h

Issue 2882043002: Update our treatment of repeating headers in tables (Closed)
Patch Set: bug 720620 Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutTableSection.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutTableSection.h b/third_party/WebKit/Source/core/layout/LayoutTableSection.h
index 8ff2023691d2d66cbccff14fe388ccd92f8bac9f..4ba5d923a45eea0eeb12620c742f147331d04710 100644
--- a/third_party/WebKit/Source/core/layout/LayoutTableSection.h
+++ b/third_party/WebKit/Source/core/layout/LayoutTableSection.h
@@ -295,7 +295,7 @@ class CORE_EXPORT LayoutTableSection final : public LayoutTableBoxComponent {
TransformState&,
VisualRectFlags = kDefaultVisualRectFlags) const override;
- bool IsRepeatingHeaderGroup() const;
+ bool IsRepeatingHeaderGroup() const { return is_repeating_header_group_; };
void UpdateLayout() override;
@@ -304,6 +304,10 @@ class CORE_EXPORT LayoutTableSection final : public LayoutTableBoxComponent {
return CellSpan(0, Table()->NumEffectiveColumns());
}
+ void DetermineIfHeaderGroupShouldRepeat() {
+ is_repeating_header_group_ = HeaderGroupShouldRepeat();
+ }
+
protected:
void StyleDidChange(StyleDifference, const ComputedStyle* old_style) override;
bool NodeAtPoint(HitTestResult&,
@@ -393,6 +397,8 @@ class CORE_EXPORT LayoutTableSection final : public LayoutTableBoxComponent {
bool PaintedOutputOfObjectHasNoEffectRegardlessOfSize() const override;
+ bool HeaderGroupShouldRepeat() const;
+
struct TableGridRow {
DISALLOW_NEW_EXCEPT_PLACEMENT_NEW();
@@ -455,6 +461,9 @@ class CORE_EXPORT LayoutTableSection final : public LayoutTableBoxComponent {
// Whether any cell spans multiple rows or cols.
bool has_spanning_cells_;
+
+ // Header group should be painted on every page.
+ bool is_repeating_header_group_;
};
DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutTableSection, IsTableSection());
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTableRow.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutTableSection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698