Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutTableRow.cpp

Issue 2882043002: Update our treatment of repeating headers in tables (Closed)
Patch Set: bug 720620 Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2013 7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2013
8 * Apple Inc. 8 * Apple Inc.
9 * All rights reserved. 9 * All rights reserved.
10 * 10 *
(...skipping 315 matching lines...) Expand 10 before | Expand all | Expand 10 after
326 cell->VisualOverflowRectForPropagation(); 326 cell->VisualOverflowRectForPropagation();
327 cell_visual_overflow_rect.Move(cell_row_offset); 327 cell_visual_overflow_rect.Move(cell_row_offset);
328 AddContentsVisualOverflow(cell_visual_overflow_rect); 328 AddContentsVisualOverflow(cell_visual_overflow_rect);
329 329
330 LayoutRect cell_layout_overflow_rect = 330 LayoutRect cell_layout_overflow_rect =
331 cell->LayoutOverflowRectForPropagation(); 331 cell->LayoutOverflowRectForPropagation();
332 cell_layout_overflow_rect.Move(cell_row_offset); 332 cell_layout_overflow_rect.Move(cell_row_offset);
333 AddLayoutOverflow(cell_layout_overflow_rect); 333 AddLayoutOverflow(cell_layout_overflow_rect);
334 } 334 }
335 335
336 bool LayoutTableRow::IsFirstRowInSectionAfterHeader() const {
337 // If there isn't room on the page for at least one content row after the
338 // header group, then we won't repeat the header on each page.
339 // https://drafts.csswg.org/css-tables-3/#repeated-headers reads like
340 // it wants us to drop headers on only the pages that a single row
341 // won't fit but we avoid the complexity of that reading until it
342 // is clarified. Tracked by crbug.com/675904
mstensho (USE GERRIT) 2017/05/22 10:40:44 That bug resolved by this CL?
rhogan 2017/05/22 18:06:04 Yes, updated.
343 if (RowIndex())
344 return false;
345 LayoutTableSection* header = Table()->Header();
346 return header && Table()->SectionAbove(Section()) == header &&
347 header->GetPaginationBreakability() != kAllowAnyBreaks;
348 }
349
350 } // namespace blink 336 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698