Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutState.h

Issue 2882043002: Update our treatment of repeating headers in tables (Closed)
Patch Set: bug 720620 Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Apple Inc. All rights reserved. 2 * Copyright (C) 2007 Apple Inc. All rights reserved.
mstensho (USE GERRIT) 2017/05/22 10:40:44 This looks like a revert of https://codereview.chr
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution. 11 * documentation and/or other materials provided with the distribution.
12 * 12 *
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 ~LayoutState(); 76 ~LayoutState();
77 77
78 bool IsPaginated() const { return is_paginated_; } 78 bool IsPaginated() const { return is_paginated_; }
79 79
80 // The page logical offset is the object's offset from the top of the page in 80 // The page logical offset is the object's offset from the top of the page in
81 // the page progression direction (so an x-offset in vertical text and a 81 // the page progression direction (so an x-offset in vertical text and a
82 // y-offset for horizontal text). 82 // y-offset for horizontal text).
83 LayoutUnit PageLogicalOffset(const LayoutBox&, 83 LayoutUnit PageLogicalOffset(const LayoutBox&,
84 const LayoutUnit& child_logical_offset) const; 84 const LayoutUnit& child_logical_offset) const;
85 85
86 LayoutUnit HeightOffsetForTableHeaders() const {
87 return height_offset_for_table_headers_;
88 };
mstensho (USE GERRIT) 2017/05/22 10:40:44 Drop the semicolon here, perhaps?
rhogan 2017/05/22 18:06:04 Done.
89 void SetHeightOffsetForTableHeaders(LayoutUnit offset) {
90 height_offset_for_table_headers_ = offset;
91 };
mstensho (USE GERRIT) 2017/05/22 10:40:44 And here
rhogan 2017/05/22 18:06:04 Done.
92
86 const LayoutSize& PaginationOffset() const { return pagination_offset_; } 93 const LayoutSize& PaginationOffset() const { return pagination_offset_; }
87 bool ContainingBlockLogicalWidthChanged() const { 94 bool ContainingBlockLogicalWidthChanged() const {
88 return containing_block_logical_width_changed_; 95 return containing_block_logical_width_changed_;
89 } 96 }
90 97
91 bool PaginationStateChanged() const { return pagination_state_changed_; } 98 bool PaginationStateChanged() const { return pagination_state_changed_; }
92 void SetPaginationStateChanged() { pagination_state_changed_ = true; } 99 void SetPaginationStateChanged() { pagination_state_changed_ = true; }
93 100
94 LayoutState* Next() const { return next_; } 101 LayoutState* Next() const { return next_; }
95 102
(...skipping 10 matching lines...) Expand all
106 bool pagination_state_changed_ : 1; 113 bool pagination_state_changed_ : 1;
107 114
108 LayoutFlowThread* flow_thread_; 115 LayoutFlowThread* flow_thread_;
109 116
110 LayoutState* next_; 117 LayoutState* next_;
111 118
112 // x/y offset from the logical top / start of the first page. Does not include 119 // x/y offset from the logical top / start of the first page. Does not include
113 // relative positioning or scroll offsets. 120 // relative positioning or scroll offsets.
114 LayoutSize pagination_offset_; 121 LayoutSize pagination_offset_;
115 122
123 // The height we need to make available for repeating table headers in
124 // paginated layout.
125 LayoutUnit height_offset_for_table_headers_;
126
116 LayoutObject& layout_object_; 127 LayoutObject& layout_object_;
117 }; 128 };
118 129
119 } // namespace blink 130 } // namespace blink
120 131
121 #endif // LayoutState_h 132 #endif // LayoutState_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698