Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 288203005: Maximize window vertically/horizontally when the maximize button is middle/right clicked on Linux (Closed)

Created:
6 years, 7 months ago by pkotwicz
Modified:
6 years, 7 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, tfarina, ben+views_chromium.org, tdanderson+views_chromium.org
Visibility:
Public.

Description

Maximize window vertically or horizontally when the maximize button is middle or right clicked on Linux respectively. BUG=362546 TEST=Manual, see bug Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271812

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -16 lines) Patch
M ui/views/widget/desktop_aura/x11_window_event_filter.h View 1 chunk +7 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/x11_window_event_filter.cc View 1 5 chunks +53 lines, -16 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
pkotwicz
Elliot, can you please take a look?
6 years, 7 months ago (2014-05-16 18:33:05 UTC) #1
Elliot Glaysher
lgtm
6 years, 7 months ago (2014-05-16 19:32:02 UTC) #2
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 7 months ago (2014-05-20 18:45:30 UTC) #3
pkotwicz
The CQ bit was unchecked by pkotwicz@chromium.org
6 years, 7 months ago (2014-05-20 18:46:05 UTC) #4
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 7 months ago (2014-05-20 18:46:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/288203005/10001
6 years, 7 months ago (2014-05-20 18:48:26 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-21 02:09:13 UTC) #7
Message was sent while issue was closed.
Change committed as 271812

Powered by Google App Engine
This is Rietveld 408576698