Hook up base unit tests and allocator to GN build.

Hook up base unit tests and allocator to GN build.

Adds a meta-target "//base/allocator" that forwards to tcmallor or nothing depending on the build configuration.

Write tcmalloc target definition.

Write base unit tests prefs, and some support targets from base.gypi.

Fix a bunch of added files in the base target that were exposed by linking the unit tests.

Removes toolkit_uses_gtk which was removed from the GYP build.

BUG=
R=scottmg@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271079

[tfarina, 2014-05-15 22:28:53]

https://codereview.chromium.org/288203003/diff/50001/base/BUILD.gn
File base/BUILD.gn (right):

https://codereview.chromium.org/288203003/diff/50001/base/BUILD.gn#newcode5
base/BUILD.gn:5: import("//build/config/android/rules.gni")
if (is_android) { 
}

https://codereview.chromium.org/288203003/diff/50001/base/BUILD.gn#newcode708
base/BUILD.gn:708: # TODO(brettw) I don"t understand the conditions this file is
used.
s/"/'

https://codereview.chromium.org/288203003/diff/50001/base/BUILD.gn#newcode776
base/BUILD.gn:776: # These things would otherwise be built on a Posix build but
aren"t
s/"/'

[brettw, 2014-05-15 22:48:22]

https://codereview.chromium.org/288203003/diff/50001/base/BUILD.gn
File base/BUILD.gn (right):

https://codereview.chromium.org/288203003/diff/50001/base/BUILD.gn#newcode5
base/BUILD.gn:5: import("//build/config/android/rules.gni")
On 2014/05/15 22:28:54, tfarina wrote:
> if (is_android) { 
> }

I think this is OK. There's nothing wrong with getting android rules on other
platforms, and I usually recomment also no ifdeffing C++ headers if they compile
on all platforms (even if they're not used).

Some .gni files won't work on all platforms, maybe we need a convention for how
this should work, but I don't have a strong opinion right now.

https://codereview.chromium.org/288203003/diff/50001/base/BUILD.gn#newcode708
base/BUILD.gn:708: # TODO(brettw) I don"t understand the conditions this file is
used.
Better yet, I just fixed this code.

[scottmg, 2014-05-15 23:37:31]

lgtm

https://codereview.chromium.org/288203003/diff/70001/base/BUILD.gn
File base/BUILD.gn (right):

https://codereview.chromium.org/288203003/diff/70001/base/BUILD.gn#newcode708
base/BUILD.gn:708: if (!is_nacl) {
is_nacl => += instead of double negation?

https://codereview.chromium.org/288203003/diff/70001/base/allocator/BUILD.gn
File base/allocator/BUILD.gn (right):

https://codereview.chromium.org/288203003/diff/70001/base/allocator/BUILD.gn#...
base/allocator/BUILD.gn:34: # We don"t list dynamic_annotations.c since its copy
is already
another " here

https://codereview.chromium.org/288203003/diff/70001/base/allocator/BUILD.gn#...
base/allocator/BUILD.gn:176: # Don"t let linker rip this symbol out, otherwise
the heap&cpu
"

[brettw, 2014-05-16 19:33:13]

Committed patchset #7 manually as r271079 (presubmit successful).