Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4045)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleCategoryPreferences.java

Issue 2882003003: [subresource_filter] Swap Allowed/Block groups in Site Settings (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleCategoryPreferences.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleCategoryPreferences.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleCategoryPreferences.java
index 8198195881a3a9c548adf7cd4188312ddbd0fe7e..1c7f26a527f87824d71659f0421360d4d65f7d79 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleCategoryPreferences.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleCategoryPreferences.java
@@ -165,6 +165,12 @@ public class SingleCategoryPreferences extends PreferenceFragment
}
}
+ // For the subresource filter permission, the Allowed list should appear first.
+ // Default collapsed settings should not change.
+ if (mCategory.showSubresourceFilterSites()) {
+ blockedGroup.setOrder(allowedGroup.getOrder() + 1);
+ }
+
// The default, when the two lists are shown for the first time, is for the
// Blocked list to be collapsed and Allowed expanded -- because the data in
// the Allowed list is normally more useful than the data in the Blocked
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698