chrome/test/chromedriver/session_commands.cc - Issue 288193004: [Chromedriver] Add Device Metrics override support to ChromeDriver via Capabilities

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/session_commands.cc

Issue 288193004: [Chromedriver] Add Device Metrics override support to ChromeDriver via Capabilities (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/chromedriver/chrome/mobile_emulation_override_manager.cc ('K') | « chrome/test/chromedriver/session.h ('k') | chrome/test/chromedriver/test/run_py_tests.py » ('j') | chrome/test/chromedriver/test/run_py_tests.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/session_commands.cc

diff --git a/chrome/test/chromedriver/session_commands.cc b/chrome/test/chromedriver/session_commands.cc

index b0ad052b4d51cf0fdb40128d450b86ff33c2fde0..864ffd7fa53459f950b43927aced3df20eac65ca 100644

--- a/chrome/test/chromedriver/session_commands.cc

+++ b/chrome/test/chromedriver/session_commands.cc

@@ -81,6 +81,8 @@ scoped_ptr<base::DictionaryValue> CreateCapabilities(Chrome* chrome) {

caps->SetBoolean("handlesAlerts", true);

caps->SetBoolean("databaseEnabled", false);

caps->SetBoolean("locationContextEnabled", true);

+ caps->SetBoolean("mobileEmulationEnabled",

+ chrome->IsMobileEmulationEnabled());

caps->SetBoolean("applicationCacheEnabled", false);

caps->SetBoolean("browserConnectionEnabled", false);

caps->SetBoolean("cssSelectorsEnabled", true);

@@ -99,7 +101,6 @@ scoped_ptr<base::DictionaryValue> CreateCapabilities(Chrome* chrome) {

return caps.Pass();

}

Status InitSessionHelper(

const InitSessionParams& bound_params,

Session* session,