chrome/test/chromedriver/client/chromedriver.py - Issue 288193004: [Chromedriver] Add Device Metrics override support to ChromeDriver via Capabilities

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/client/chromedriver.py

Issue 288193004: [Chromedriver] Add Device Metrics override support to ChromeDriver via Capabilities (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/chromedriver/chrome/mobile_emulation_override_manager.cc ('K') | « chrome/test/chromedriver/chrome_launcher.cc ('k') | chrome/test/chromedriver/client/webelement.py » ('j') | chrome/test/chromedriver/test/run_py_tests.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/client/chromedriver.py

diff --git a/chrome/test/chromedriver/client/chromedriver.py b/chrome/test/chromedriver/client/chromedriver.py

index 946f85cbaf883f8455d7adee17b03da10ad3824a..063de9900b0af66972a521b21f6dd3d7b3d50ef3 100644

--- a/chrome/test/chromedriver/client/chromedriver.py

+++ b/chrome/test/chromedriver/client/chromedriver.py

@@ -65,7 +65,7 @@ class ChromeDriver(object):

android_use_running_app=None, chrome_switches=None,

chrome_extensions=None, chrome_log_path=None,

debugger_address=None, browser_log_level=None,

- experimental_options=None):

+ mobile_emulation=None, experimental_options=None):

self._executor = command_executor.CommandExecutor(server_url)

options = {}

@@ -89,6 +89,10 @@ class ChromeDriver(object):

assert type(chrome_switches) is list

options['args'] = chrome_switches

+ if mobile_emulation:

+ assert type(mobile_emulation) is dict

+ options['mobileEmulation'] = mobile_emulation

if chrome_extensions:

assert type(chrome_extensions) is list

options['extensions'] = chrome_extensions