Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: chrome/test/chromedriver/chrome/chrome_impl.cc

Issue 288193004: [Chromedriver] Add Device Metrics override support to ChromeDriver via Capabilities (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/chrome_impl.cc
diff --git a/chrome/test/chromedriver/chrome/chrome_impl.cc b/chrome/test/chromedriver/chrome/chrome_impl.cc
index f0b87d653af8bf53d3b3f224e91f8bf8e1afbcee..7f796d2e653c0c415e2d472d9b6e088587028b00 100644
--- a/chrome/test/chromedriver/chrome/chrome_impl.cc
+++ b/chrome/test/chromedriver/chrome/chrome_impl.cc
@@ -83,7 +83,10 @@ Status ChromeImpl::GetWebViewIds(std::list<std::string>* web_view_ids) {
// OnConnected will fire when DevToolsClient connects later.
}
web_views_.push_back(make_linked_ptr(new WebViewImpl(
- view.id, devtools_http_client_->browser_info(), client.Pass())));
+ view.id,
+ devtools_http_client_->browser_info(),
+ client.Pass(),
+ devtools_http_client_->device_metrics())));
}
}
@@ -125,6 +128,10 @@ Status ChromeImpl::ActivateWebView(const std::string& id) {
return devtools_http_client_->ActivateWebView(id);
}
+bool ChromeImpl::IsMobileEmulationEnabled() const {
+ return false;
+}
+
Status ChromeImpl::Quit() {
Status status = QuitImpl();
if (status.IsOk())

Powered by Google App Engine
This is Rietveld 408576698