[SyncFS] Construct and destruct sync_worker in worker_task_runner

chrome/browser/sync_file_system/drive_backend/sync_worker.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SYNC_FILE_SYSTEM_DRIVE_BACKEND_SYNC_WORKER_H_
 #define CHROME_BROWSER_SYNC_FILE_SYSTEM_DRIVE_BACKEND_SYNC_WORKER_H_
 
 #include <set>
 #include <string>
 
@@ skipping 31 matching lines @@
 
 namespace drive_backend {
 
 class LocalToRemoteSyncer;
 class MetadataDatabase;
 class RemoteChangeProcessorOnWorker;
 class RemoteToLocalSyncer;
 class SyncEngineContext;
 class SyncEngineInitializer;
 
-class SyncWorker : public SyncTaskManager::Client {
+class SyncWorker : public SyncTaskManager::Client,
+                   public base::SupportsWeakPtr<SyncWorker> {

[tzik, 2014/05/26 06:50:21]

please revert this.

[peria, 2014/05/26 07:55:09]

Done.

  public:
   enum AppStatus {
     APP_STATUS_ENABLED,
     APP_STATUS_DISABLED,
     APP_STATUS_UNINSTALLED,
   };
 
   typedef base::hash_map<std::string, AppStatus> AppStatusMap;
 
   class Observer {
    public:
+    virtual ~Observer() {}

[tzik, 2014/05/26 06:50:21]

Not need to public?

[peria, 2014/05/26 07:55:09]

Done.

+
     virtual void OnPendingFileListUpdated(int item_count) = 0;
     virtual void OnFileStatusChanged(const fileapi::FileSystemURL& url,
                                      SyncFileStatus file_status,
                                      SyncAction sync_action,
                                      SyncDirection direction) = 0;
     virtual void UpdateServiceState(RemoteServiceState state,
                                     const std::string& description) = 0;
-
-   protected:
-    virtual ~Observer() {}
   };
 
   static scoped_ptr<SyncWorker> CreateOnWorker(
       const base::FilePath& base_dir,
       Observer* observer,
       const base::WeakPtr<ExtensionServiceInterface>& extension_service,
       scoped_ptr<SyncEngineContext> sync_engine_context,
       leveldb::Env* env_override);
 
   virtual ~SyncWorker();
@@ skipping 104 matching lines @@
   ConflictResolutionPolicy default_conflict_resolution_policy_;
   bool network_available_;
 
   scoped_ptr<SyncTaskManager> task_manager_;
 
   base::WeakPtr<ExtensionServiceInterface> extension_service_;
 
   scoped_ptr<SyncEngineContext> context_;
   ObserverList<Observer> observers_;
 
-  base::WeakPtrFactory<SyncWorker> weak_ptr_factory_;
   DISALLOW_COPY_AND_ASSIGN(SyncWorker);
 };
 
 }  // namespace drive_backend
 }  // namespace sync_file_system
 
 #endif  // CHROME_BROWSER_SYNC_FILE_SYSTEM_DRIVE_BACKEND_SYNC_WORKER_H_