tools/testing/dart/test_configurations.dart - Issue 2881833003: Reuse -cdartk for vm testing with Dart Frontend parser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/testing/dart/test_configurations.dart

Issue 2881833003: Reuse -cdartk for vm testing with Dart Frontend parser. (Closed)

Patch Set: Remove dependency on https://codereview.chromium.org/2881953002. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/testing/dart/test_configurations.dart

diff --git a/tools/testing/dart/test_configurations.dart b/tools/testing/dart/test_configurations.dart

index 7e690fe212a1b81fa9910b2e5d8633bc99107c36..bffb8629af7ac09004abb50b18df2ec74af6cab3 100644

--- a/tools/testing/dart/test_configurations.dart

+++ b/tools/testing/dart/test_configurations.dart

@@ -199,7 +199,8 @@ Future testConfigurations(List<Map> configurations) async {

for (String key in selectors.keys) {

if (key == 'co19') {

testSuites.add(new Co19TestSuite(conf));

- } else if (conf['compiler'] == 'none' &&

+ } else if ((conf['compiler'] == 'dartk' ||

+ conf['compiler'] == 'none') &&

conf['runtime'] == 'vm' &&

key == 'vm') {

// vm tests contain both cc tests (added here) and dart tests (added

« no previous file with comments | « no previous file | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »