Reuse -cdartk for vm testing with Dart Frontend parser.

With this change 'tools/test.py -cdartk vm' will run vm tests with Dart Frontend parser.

BUG=https://github.com/dart-lang/sdk/issues/28264
R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/f62a2a95629f2f186851eeaf1888826b12d4968c

[aam, 2017-05-12 23:19:53]

aam@google.com changed reviewers:
+ asiva@google.com

[aam, 2017-05-12 23:24:08]

Description was changed from

==========
Introduce new test script option to run VM tests with kernel snapshot.

BUG=
==========

to

==========
Introduce new test script option to run VM tests with kernel snapshot.

BUG=https://github.com/dart-lang/sdk/issues/28264
==========

[siva, 2017-05-15 04:42:56]

https://codereview.chromium.org/2881833003/diff/1/tools/testing/dart/test_sui...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/2881833003/diff/1/tools/testing/dart/test_sui...
tools/testing/dart/test_suite.dart:2048: args.add("--use_dart_frontend");
Why not use the same scheme as used with the compiler=dartk option in the
regular testing it picks up the kernel snapshot from
{buildDir}/gen/kernel-service.dart.snapshot

[aam, 2017-05-16 00:18:02]

https://codereview.chromium.org/2881833003/diff/1/tools/testing/dart/test_sui...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/2881833003/diff/1/tools/testing/dart/test_sui...
tools/testing/dart/test_suite.dart:2048: args.add("--use_dart_frontend");
On 2017/05/15 at 04:42:56, siva wrote:
> Why not use the same scheme as used with the compiler=dartk option in the
regular testing it picks up the kernel snapshot from
{buildDir}/gen/kernel-service.dart.snapshot

If we are to support vm testing with or without kernel parser we still would
have to introduce an option. Or were you thinking something along the lines of
introducing new compiler(something like none_dfe as alternative to none)?
If we are to introduce an option, I thought we might as well make it a
string(snapshot name), rather than a boolean option(dfe)?

[siva, 2017-05-17 18:36:47]

https://codereview.chromium.org/2881833003/diff/1/tools/testing/dart/test_sui...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/2881833003/diff/1/tools/testing/dart/test_sui...
tools/testing/dart/test_suite.dart:2048: args.add("--use_dart_frontend");
On 2017/05/16 00:18:02, aam wrote:
> On 2017/05/15 at 04:42:56, siva wrote:
> > Why not use the same scheme as used with the compiler=dartk option in the
> regular testing it picks up the kernel snapshot from
> {buildDir}/gen/kernel-service.dart.snapshot
> 
> If we are to support vm testing with or without kernel parser we still would
> have to introduce an option. Or were you thinking something along the lines of
> introducing new compiler(something like none_dfe as alternative to none)?
> If we are to introduce an option, I thought we might as well make it a
> string(snapshot name), rather than a boolean option(dfe)?

I was thinking if we changed test_configuration.dart to include compiler ==
dartk we would be able to reuse all the stuff that is setup for dartk in the
regular tests

            (conf['compiler'] == 'none' || conf['compiler'] == 'dartk') &&
            conf['runtime'] == 'vm' &&
            key == 'vm') {
          // vm tests contain both cc tests (added here) and dart tests (added
          // in [TEST_SUITE_DIRECTORIES]).
          testSuites.add(new VMTestSuite(conf));

Then we should be able to run the test as 

tools/test.py -cdartk vm

[aam, 2017-05-17 21:45:51]

On 2017/05/17 at 18:36:47, asiva wrote:
>
https://codereview.chromium.org/2881833003/diff/1/tools/testing/dart/test_sui...
> File tools/testing/dart/test_suite.dart (right):
> 
>
https://codereview.chromium.org/2881833003/diff/1/tools/testing/dart/test_sui...
> tools/testing/dart/test_suite.dart:2048: args.add("--use_dart_frontend");
> On 2017/05/16 00:18:02, aam wrote:
> > On 2017/05/15 at 04:42:56, siva wrote:
> > > Why not use the same scheme as used with the compiler=dartk option in the
> > regular testing it picks up the kernel snapshot from
> > {buildDir}/gen/kernel-service.dart.snapshot
> > 
> > If we are to support vm testing with or without kernel parser we still would
> > have to introduce an option. Or were you thinking something along the lines
of
> > introducing new compiler(something like none_dfe as alternative to none)?
> > If we are to introduce an option, I thought we might as well make it a
> > string(snapshot name), rather than a boolean option(dfe)?
> 
> I was thinking if we changed test_configuration.dart to include compiler ==
dartk we would be able to reuse all the stuff that is setup for dartk in the
regular tests
> 
>             (conf['compiler'] == 'none' || conf['compiler'] == 'dartk') &&
>             conf['runtime'] == 'vm' &&
>             key == 'vm') {
>           // vm tests contain both cc tests (added here) and dart tests (added
>           // in [TEST_SUITE_DIRECTORIES]).
>           testSuites.add(new VMTestSuite(conf));
> 
> Then we should be able to run the test as 
> 
> tools/test.py -cdartk vm

Done.

[siva, 2017-05-17 22:06:11]

lgtm

[aam, 2017-05-17 23:12:47]

Description was changed from

==========
Introduce new test script option to run VM tests with kernel snapshot.

BUG=https://github.com/dart-lang/sdk/issues/28264
==========

to

==========
With this change 'tools/test.py -cdartk vm' will run vm tests with Dart Frontend
parser.

BUG=https://github.com/dart-lang/sdk/issues/28264
==========

[aam, 2017-05-23 00:24:42]

Description was changed from

==========
With this change 'tools/test.py -cdartk vm' will run vm tests with Dart Frontend
parser.

BUG=https://github.com/dart-lang/sdk/issues/28264
==========

to

==========
With this change 'tools/test.py -cdartk vm' will run vm tests with Dart Frontend
parser.

BUG=https://github.com/dart-lang/sdk/issues/28264
R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/f62a2a95629f2f186851eeaf1888826b12d4968c
==========

[aam, 2017-05-23 00:24:43]

Committed patchset #4 (id:60001) manually as
f62a2a95629f2f186851eeaf1888826b12d4968c (presubmit successful).