Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(944)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/accessibility/KitKatBrowserAccessibilityManager.java

Issue 2881723002: Fix TalkBack feedback for password fields in Android O (Closed)
Patch Set: Address feedback Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/accessibility/KitKatBrowserAccessibilityManager.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/accessibility/KitKatBrowserAccessibilityManager.java b/content/public/android/java/src/org/chromium/content/browser/accessibility/KitKatBrowserAccessibilityManager.java
index 0fc2bbbbac6133fe5e905a7301fa967c51ee08bd..58ea5d88c83ed70b5fc0eafcb06ca42c44c9e0fc 100644
--- a/content/public/android/java/src/org/chromium/content/browser/accessibility/KitKatBrowserAccessibilityManager.java
+++ b/content/public/android/java/src/org/chromium/content/browser/accessibility/KitKatBrowserAccessibilityManager.java
@@ -29,7 +29,8 @@ public class KitKatBrowserAccessibilityManager extends BrowserAccessibilityManag
@Override
protected void setAccessibilityNodeInfoKitKatAttributes(AccessibilityNodeInfo node,
- boolean isRoot, boolean isEditableText, String roleDescription) {
+ boolean isRoot, boolean isEditableText, String roleDescription, int selectionStartIndex,
+ int selectionEndIndex) {
Bundle bundle = node.getExtras();
bundle.putCharSequence("AccessibilityNodeInfo.roleDescription", roleDescription);
if (isRoot) {
@@ -38,6 +39,7 @@ public class KitKatBrowserAccessibilityManager extends BrowserAccessibilityManag
}
if (isEditableText) {
node.setEditable(true);
+ node.setTextSelection(selectionStartIndex, selectionEndIndex);
}
}
}

Powered by Google App Engine
This is Rietveld 408576698