content/browser/accessibility/browser_accessibility.cc - Issue 2881723002: Fix TalkBack feedback for password fields in Android O

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility.cc

Issue 2881723002: Fix TalkBack feedback for password fields in Android O (Closed)

Patch Set: Address feedback Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/accessibility/browser_accessibility.cc

diff --git a/content/browser/accessibility/browser_accessibility.cc b/content/browser/accessibility/browser_accessibility.cc

index 7d50b00c3cba768e9f68278a14bc5328a74d2edd..4e96eb28e5a3bdf2a074ef3674a1bcc3c4840b0c 100644

--- a/content/browser/accessibility/browser_accessibility.cc

+++ b/content/browser/accessibility/browser_accessibility.cc

@@ -1028,7 +1028,7 @@ bool BrowserAccessibility::HasExplicitlyEmptyName() const {

ui::AX_NAME_FROM_ATTRIBUTE_EXPLICITLY_EMPTY;

}

-std::string BrowserAccessibility::ComputeAccessibleNameFromDescendants() {

+std::string BrowserAccessibility::ComputeAccessibleNameFromDescendants() const {

std::string name;

for (size_t i = 0; i < InternalChildCount(); ++i) {

BrowserAccessibility* child = InternalGetChild(i);