Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Unified Diff: third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp

Issue 2881673003: CSS Motion Path: Support parsing of ray(<angle>) paths (Closed)
Patch Set: CSS values in BasicShapeFunctions not StyleRay Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
diff --git a/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp b/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
index a3cc0af32a0cd5f1a141ca5101b1bde0d25607a7..e9b5f2a3ee8a02021e22175aa5a719a07a816834 100644
--- a/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
+++ b/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
@@ -26,6 +26,7 @@
#include "core/css/resolver/StyleBuilderConverter.h"
+#include <algorithm>
#include "core/css/BasicShapeFunctions.h"
#include "core/css/CSSBasicShapeValues.h"
#include "core/css/CSSColorValue.h"
@@ -41,6 +42,7 @@
#include "core/css/CSSPathValue.h"
#include "core/css/CSSPrimitiveValueMappings.h"
#include "core/css/CSSQuadValue.h"
+#include "core/css/CSSRayValue.h"
fs 2017/05/15 11:05:39 Nit: No longer needed I think?
Eric Willigers 2017/05/15 11:12:12 Removed.
#include "core/css/CSSReflectValue.h"
#include "core/css/CSSShadowValue.h"
#include "core/css/CSSStringValue.h"
@@ -51,13 +53,13 @@
#include "core/frame/LocalFrame.h"
#include "core/frame/UseCounter.h"
#include "core/style/ClipPathOperation.h"
+#include "core/style/StyleRay.h"
fs 2017/05/15 11:05:39 Ditto.
Eric Willigers 2017/05/15 11:12:12 Removed.
#include "core/style/TextSizeAdjust.h"
#include "core/svg/SVGURIReference.h"
#include "platform/fonts/FontCache.h"
#include "platform/transforms/RotateTransformOperation.h"
#include "platform/transforms/ScaleTransformOperation.h"
#include "platform/transforms/TranslateTransformOperation.h"
-#include <algorithm>
namespace blink {
@@ -1380,6 +1382,14 @@ PassRefPtr<StylePath> StyleBuilderConverter::ConvertPathOrNone(
return nullptr;
}
+PassRefPtr<BasicShape> StyleBuilderConverter::ConvertOffsetPath(
+ StyleResolverState& state,
+ const CSSValue& value) {
+ if (value.IsRayValue())
+ return BasicShapeForValue(state, value);
+ return ConvertPathOrNone(state, value);
+}
+
static const CSSValue& ComputeRegisteredPropertyValue(
const CSSToLengthConversionData& css_to_length_conversion_data,
const CSSValue& value) {

Powered by Google App Engine
This is Rietveld 408576698