Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(750)

Unified Diff: third_party/WebKit/Source/core/style/StylePath.cpp

Issue 2881673003: CSS Motion Path: Support parsing of ray(<angle>) paths (Closed)
Patch Set: size contain? Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/style/StylePath.cpp
diff --git a/third_party/WebKit/Source/core/style/StylePath.cpp b/third_party/WebKit/Source/core/style/StylePath.cpp
index 2b60756c3b788d7851366de69a6b8d2bc9156330..807d2e06360f2c5fcc5f8024d208985aebeb322e 100644
--- a/third_party/WebKit/Source/core/style/StylePath.cpp
+++ b/third_party/WebKit/Source/core/style/StylePath.cpp
@@ -54,8 +54,22 @@ CSSValue* StylePath::ComputedCSSValue() const {
return CSSPathValue::Create(const_cast<StylePath*>(this));
}
-bool StylePath::operator==(const StylePath& other) const {
+bool StylePath::operator==(const BasicShape& o) const {
+ if (!IsSameType(o))
+ return false;
+ const StylePath& other = ToStylePath(o);
return *byte_stream_ == *other.byte_stream_;
}
+void StylePath::GetPath(Path&, const FloatRect&) {
+ // Callers should use GetPath() overload, which avoids making a copy.
+ NOTREACHED();
+}
+
+PassRefPtr<BasicShape> StylePath::Blend(const BasicShape*, double) const {
+ // FIXME(ericwilligers): Implement animation for offset-path.
fs 2017/05/15 09:18:14 TODO(...) per current guidelines
Eric Willigers 2017/05/15 10:52:23 Done.
+ NOTREACHED();
+ return nullptr;
+}
+
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698