third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp - Issue 2881673003: CSS Motion Path: Support parsing of ray(<angle>) paths

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

Issue 2881673003: CSS Motion Path: Support parsing of ray(<angle>) paths (Closed)

Patch Set: DCHECK_EQ Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/css-parser/offset-path-parsing.html ('K') | « third_party/WebKit/Source/core/css/CSSValueKeywords.json5 ('k') | third_party/WebKit/Source/core/css/properties/CSSPropertyOffsetPathUtils.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

diff --git a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

index 86e57236fd9e1d4302daf2f696fd9bfd9ae72581..39124fac467439e890257eafb3ba8f60a9498469 100644

--- a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

+++ b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

@@ -3437,8 +3437,8 @@ const CSSValue* ComputedStyleCSSValueMapping::Get(

return ValueForPosition(style.OffsetPosition(), style);

case CSSPropertyOffsetPath:

- if (const StylePath* style_motion_path = style.OffsetPath())

- return style_motion_path->ComputedCSSValue();

+ if (const BasicShape* style_motion_path = style.OffsetPath())

+ return ValueForBasicShape(style, style_motion_path);

return CSSIdentifierValue::Create(CSSValueNone);

case CSSPropertyOffsetDistance: