CSS Motion Path: Support parsing of ray(<angle>) paths

third_party/WebKit/Source/core/css/BasicShapeFunctions.cpp

 /*
  * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1. Redistributions of source code must retain the above
  *    copyright notice, this list of conditions and the following
  *    disclaimer.
@@ skipping 14 matching lines @@
  * TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF
  * THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
  * SUCH DAMAGE.
  */
 
 #include "core/css/BasicShapeFunctions.h"
 
 #include "core/css/CSSBasicShapeValues.h"
 #include "core/css/CSSIdentifierValue.h"
 #include "core/css/CSSPrimitiveValueMappings.h"
+#include "core/css/CSSRayValue.h"

[fs, 2017/05/15 09:18:14]

(Only needed because StyleRay returns CSSRayValue - does it have to? Could it
return a plain CSSValue*?)

[Eric Willigers, 2017/05/15 10:52:23]

Done, then undone because ValueForBasicShape now calls CSSRayValue::Create.

 #include "core/css/CSSValuePair.h"
 #include "core/css/resolver/StyleResolverState.h"
 #include "core/style/BasicShapes.h"
 #include "core/style/ComputedStyle.h"
+#include "core/style/StyleRay.h"
 
 namespace blink {
 
 static CSSValue* ValueForCenterCoordinate(
     const ComputedStyle& style,
     const BasicShapeCenterCoordinate& center,
     EBoxOrient orientation) {
   if (center.GetDirection() == BasicShapeCenterCoordinate::kTopLeft)
     return CSSValue::Create(center.length(), style.EffectiveZoom());
 
@@ skipping 25 matching lines @@
       return CSSIdentifierValue::Create(CSSValueFarthestSide);
   }
 
   NOTREACHED();
   return nullptr;
 }
 
 CSSValue* ValueForBasicShape(const ComputedStyle& style,
                              const BasicShape* basic_shape) {
   switch (basic_shape->GetType()) {
+    case BasicShape::kStyleRayType:
+      return ToStyleRay(basic_shape)->ComputedCSSValue();
+
+    case BasicShape::kStylePathType:
+      return ToStylePath(basic_shape)->ComputedCSSValue();
+
     case BasicShape::kBasicShapeCircleType: {
       const BasicShapeCircle* circle = ToBasicShapeCircle(basic_shape);
       CSSBasicShapeCircleValue* circle_value =
           CSSBasicShapeCircleValue::Create();
 
       circle_value->SetCenterX(
           ValueForCenterCoordinate(style, circle->CenterX(), HORIZONTAL));
       circle_value->SetCenterY(
           ValueForCenterCoordinate(style, circle->CenterY(), VERTICAL));
       circle_value->SetRadius(
@@ skipping 211 matching lines @@
 FloatPoint FloatPointForCenterCoordinate(
     const BasicShapeCenterCoordinate& center_x,
     const BasicShapeCenterCoordinate& center_y,
     FloatSize box_size) {
   float x = FloatValueForLength(center_x.ComputedLength(), box_size.Width());
   float y = FloatValueForLength(center_y.ComputedLength(), box_size.Height());
   return FloatPoint(x, y);
 }
 
 }  // namespace blink