remoting/host/ipc_host_event_logger.cc - Issue 2881673002: Avoid heap allocations in IPAddress

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/host/ipc_host_event_logger.cc

Issue 2881673002: Avoid heap allocations in IPAddress (Closed)

Patch Set: New constructor Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/host/ipc_host_event_logger.cc

diff --git a/remoting/host/ipc_host_event_logger.cc b/remoting/host/ipc_host_event_logger.cc

index 3ebebc6fbcc2877c40f6b9857d53edac95bd2182..154ac607483ff89bd9e1fa00f488deaecc26ad15 100644

--- a/remoting/host/ipc_host_event_logger.cc

+++ b/remoting/host/ipc_host_event_logger.cc

@@ -60,9 +60,10 @@ void IpcHostEventLogger::OnClientRouteChange(

SerializedTransportRoute serialized_route;

serialized_route.type = route.type;

- serialized_route.remote_ip = route.remote_address.address().bytes();

+ serialized_route.remote_ip =

+ route.remote_address.address().CopyBytesToVector();

serialized_route.remote_port = route.remote_address.port();

- serialized_route.local_ip = route.local_address.address().bytes();

+ serialized_route.local_ip = route.local_address.address().CopyBytesToVector();

serialized_route.local_port = route.local_address.port();

daemon_channel_->Send(new ChromotingNetworkDaemonMsg_ClientRouteChange(

jid, channel_name, serialized_route));

« no previous file with comments | « remoting/host/daemon_process.cc ('k') | tools/ipc_fuzzer/fuzzer/fuzzer.cc » ('j') | no next file with comments »