Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: ppapi/shared_impl/private/net_address_private_impl.h

Issue 2881673002: Avoid heap allocations in IPAddress (Closed)
Patch Set: New constructor Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/shared_impl/BUILD.gn ('k') | ppapi/shared_impl/private/net_address_private_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/shared_impl/private/net_address_private_impl.h
diff --git a/ppapi/shared_impl/private/net_address_private_impl.h b/ppapi/shared_impl/private/net_address_private_impl.h
index dd4b56a821a801dde83969d9b6c3f0c600b1c436..dcd8ce95353ad1c4fec83f30690cfa150af9d3dd 100644
--- a/ppapi/shared_impl/private/net_address_private_impl.h
+++ b/ppapi/shared_impl/private/net_address_private_impl.h
@@ -7,9 +7,9 @@
#include <stdint.h>
#include <string>
-#include <vector>
#include "base/macros.h"
+#include "net/base/ip_address.h"
#include "ppapi/c/pp_stdint.h"
#include "ppapi/c/ppb_net_address.h"
#include "ppapi/shared_impl/ppapi_shared_export.h"
@@ -27,12 +27,12 @@ class PPAPI_SHARED_EXPORT NetAddressPrivateImpl {
uint32_t sa_length,
PP_NetAddress_Private* net_addr);
- static bool IPEndPointToNetAddress(const std::vector<uint8_t>& address,
+ static bool IPEndPointToNetAddress(const net::IPAddressBytes& address,
uint16_t port,
PP_NetAddress_Private* net_addr);
static bool NetAddressToIPEndPoint(const PP_NetAddress_Private& net_addr,
- std::vector<uint8_t>* address,
+ net::IPAddressBytes* address,
uint16_t* port);
static std::string DescribeNetAddress(const PP_NetAddress_Private& addr,
« no previous file with comments | « ppapi/shared_impl/BUILD.gn ('k') | ppapi/shared_impl/private/net_address_private_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698