tools/ipc_fuzzer/fuzzer/fuzzer.cc - Issue 2881673002: Avoid heap allocations in IPAddress

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/ipc_fuzzer/fuzzer/fuzzer.cc

Issue 2881673002: Avoid heap allocations in IPAddress (Closed)

Patch Set: Done Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/ipc_fuzzer/fuzzer/fuzzer.cc

diff --git a/tools/ipc_fuzzer/fuzzer/fuzzer.cc b/tools/ipc_fuzzer/fuzzer/fuzzer.cc

index a8d3c6c4f3801901bf88ad6839c9abca5a47afdd..182b0039dc8448e332e1dd56630f9150010ad34a 100644

--- a/tools/ipc_fuzzer/fuzzer/fuzzer.cc

+++ b/tools/ipc_fuzzer/fuzzer/fuzzer.cc

@@ -1291,7 +1291,7 @@ struct FuzzTraits<net::HostPortPair> {

template <>

struct FuzzTraits<net::IPAddress> {

static bool Fuzz(net::IPAddress* p, Fuzzer* fuzzer) {

- std::vector<uint8_t> bytes = p->bytes();

+ std::vector<uint8_t> bytes = p->CopyBytesToVector();

if (!FuzzParam(&bytes, fuzzer))

return false;

net::IPAddress ip_address(bytes);