net/interfaces/ip_address_struct_traits.cc - Issue 2881673002: Avoid heap allocations in IPAddress

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/interfaces/ip_address_struct_traits.cc

Issue 2881673002: Avoid heap allocations in IPAddress (Closed)

Patch Set: Address comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/interfaces/ip_address_struct_traits.cc

diff --git a/net/interfaces/ip_address_struct_traits.cc b/net/interfaces/ip_address_struct_traits.cc

index b23ac880cb0043e05569ce9b5b826ecd77953607..e93b13e5400d7f812a30f266eb7328ef8c35e365 100644

--- a/net/interfaces/ip_address_struct_traits.cc

+++ b/net/interfaces/ip_address_struct_traits.cc

@@ -13,7 +13,7 @@ bool StructTraits<net::interfaces::IPAddressDataView, net::IPAddress>::Read(

if (!data.ReadAddress(&bytes))

return false;

- *out = net::IPAddress(bytes);

+ *out = net::IPAddress(bytes.data(), bytes.size());

return out->IsValid();

}