net/dns/mojo_host_struct_traits.cc - Issue 2881673002: Avoid heap allocations in IPAddress

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/dns/mojo_host_struct_traits.cc

Issue 2881673002: Avoid heap allocations in IPAddress (Closed)

Patch Set: Address comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/dns/mojo_host_struct_traits.cc

diff --git a/net/dns/mojo_host_struct_traits.cc b/net/dns/mojo_host_struct_traits.cc

index 09f167323a1761fd92b6977256f3ab867f8d10f9..93f3baf3f655eacc8a0e9a791c45a035b369b4ce 100644

--- a/net/dns/mojo_host_struct_traits.cc

+++ b/net/dns/mojo_host_struct_traits.cc

@@ -76,7 +76,8 @@ bool StructTraits<net::interfaces::IPEndPointDataView, net::IPEndPoint>::Read(

if (!data.ReadAddress(&bytes))

return false;

- *out = net::IPEndPoint(net::IPAddress(bytes), data.port());

+ *out =

+ net::IPEndPoint(net::IPAddress(bytes.data(), bytes.size()), data.port());

return true;

}