content/browser/renderer_host/pepper/pepper_tcp_server_socket_message_filter.cc - Issue 2881673002: Avoid heap allocations in IPAddress

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/pepper/pepper_tcp_server_socket_message_filter.cc

Issue 2881673002: Avoid heap allocations in IPAddress (Closed)

Patch Set: Address comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/pepper/pepper_socket_utils.cc ('k') | content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc » ('j') | net/base/ip_address.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/pepper/pepper_tcp_server_socket_message_filter.cc

diff --git a/content/browser/renderer_host/pepper/pepper_tcp_server_socket_message_filter.cc b/content/browser/renderer_host/pepper/pepper_tcp_server_socket_message_filter.cc

index 50484811508e190b6a908ebb24f27012f7c845b7..4cee8a58bc68e488b6912084266b23a5b58e3c6f 100644

--- a/content/browser/renderer_host/pepper/pepper_tcp_server_socket_message_filter.cc

+++ b/content/browser/renderer_host/pepper/pepper_tcp_server_socket_message_filter.cc

@@ -174,7 +174,7 @@ void PepperTCPServerSocketMessageFilter::DoListen(

int32_t backlog) {

DCHECK_CURRENTLY_ON(BrowserThread::IO);

- std::vector<uint8_t> address;

+ net::IPAddress::IPAddressBytes address;

uint16_t port;

if (state_ != STATE_BEFORE_LISTENING ||

!NetAddressPrivateImpl::NetAddressToIPEndPoint(addr, &address, &port)) {

@@ -188,7 +188,8 @@ void PepperTCPServerSocketMessageFilter::DoListen(

socket_.reset(new net::TCPSocket(NULL, NULL, net::NetLogSource()));

int net_result = net::OK;

do {

- net::IPEndPoint ip_end_point(net::IPAddress(address), port);

+ net::IPEndPoint ip_end_point(net::IPAddress(address.data(), address.size()),

+ port);

net_result = socket_->Open(ip_end_point.GetFamily());

if (net_result != net::OK)

break;