Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1937)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/public/common/common_param_traits.cc

Issue 2881673002: Avoid heap allocations in IPAddress (Closed)
Patch Set: DCHECK Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/media/webrtc/webrtc_text_log_handler.cc ('k') | net/base/ip_address.h » ('j') | net/base/ip_address.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/common/common_param_traits.cc
diff --git a/content/public/common/common_param_traits.cc b/content/public/common/common_param_traits.cc
index 286e6621cc6212cf727ba636c44d4df4a0ba6ceb..149804d8119f5f9adcce333c4cb3cdbc89ddfce1 100644
--- a/content/public/common/common_param_traits.cc
+++ b/content/public/common/common_param_traits.cc
@@ -124,11 +124,13 @@ void ParamTraits<net::IPEndPoint>::Log(const param_type& p, std::string* l) {
void ParamTraits<net::IPAddress>::GetSize(base::PickleSizer* s,
const param_type& p) {
- GetParamSize(s, p.bytes());
+ for (uint8_t byte : p.bytes())
+ GetParamSize(s, byte);
}
void ParamTraits<net::IPAddress>::Write(base::Pickle* m, const param_type& p) {
- WriteParam(m, p.bytes());
+ for (uint8_t byte : p.bytes())
+ WriteParam(m, byte);
}
bool ParamTraits<net::IPAddress>::Read(const base::Pickle* m,
« no previous file with comments | « chrome/browser/media/webrtc/webrtc_text_log_handler.cc ('k') | net/base/ip_address.h » ('j') | net/base/ip_address.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698