Avoid heap allocations in IPAddress

ppapi/shared_impl/private/net_address_private_impl.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef PPAPI_SHARED_IMPL_PRIVATE_NET_ADDRESS_PRIVATE_IMPL_H_
 #define PPAPI_SHARED_IMPL_PRIVATE_NET_ADDRESS_PRIVATE_IMPL_H_
 
 #include <stdint.h>
 #include <string>
-#include <vector>
 
+#include "base/containers/stack_container.h"
 #include "base/macros.h"
+#include "net/base/ip_address.h"
 #include "ppapi/c/pp_stdint.h"
 #include "ppapi/c/ppb_net_address.h"
 #include "ppapi/shared_impl/ppapi_shared_export.h"
 
 struct PP_NetAddress_Private;
 struct sockaddr;
 
 namespace ppapi {
 
 class PPAPI_SHARED_EXPORT NetAddressPrivateImpl {
  public:
   static bool ValidateNetAddress(const PP_NetAddress_Private& addr);
 
   static bool SockaddrToNetAddress(const sockaddr* sa,
                                    uint32_t sa_length,
                                    PP_NetAddress_Private* net_addr);
 
-  static bool IPEndPointToNetAddress(const std::vector<uint8_t>& address,
-                                     uint16_t port,
-                                     PP_NetAddress_Private* net_addr);
+  static bool IPEndPointToNetAddress(
+      const net::IPAddress::IPAddressBytes& address,
+      uint16_t port,
+      PP_NetAddress_Private* net_addr);
 
   static bool NetAddressToIPEndPoint(const PP_NetAddress_Private& net_addr,
-                                     std::vector<uint8_t>* address,
+                                     base::StackVector<uint8_t, 16>* address,

[eroman, 2017/05/19 22:00:07]

Can this be changed to a IPAddressBytes? That would make it symmetric with the
function above which does the reverse (and takes IPAddressBytes).

[Ryan Hamilton, 2017/05/20 03:21:44]

Done.

                                      uint16_t* port);
 
   static std::string DescribeNetAddress(const PP_NetAddress_Private& addr,
                                         bool include_port);
 
   static void GetAnyAddress(PP_Bool is_ipv6, PP_NetAddress_Private* addr);
 
   // Conversion methods to make PPB_NetAddress resource work with
   // PP_NetAddress_Private.
   // TODO(yzshen): Remove them once PPB_NetAddress resource doesn't use
@@ skipping 15 matching lines @@
 
   static const PP_NetAddress_Private kInvalidNetAddress;
 
  private:
   DISALLOW_IMPLICIT_CONSTRUCTORS(NetAddressPrivateImpl);
 };
 
 }  // namespace ppapi
 
 #endif  // PPAPI_SHARED_IMPL_PRIVATE_NET_ADDRESS_PRIVATE_IMPL_H_