Avoid heap allocations in IPAddress

net/base/ip_address_unittest.cc

 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/ip_address.h"
 
 #include <vector>
 
 #include "base/format_macros.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 172 matching lines @@
                // Unreserved block(s)
                {"203.0.114.0", NOT_RESERVED},
                {"223.255.255.255", NOT_RESERVED},
                // 224.0.0.0/8 - 255.0.0.0/8
                {"224.0.0.0", RESERVED},
                {"255.255.255.255", RESERVED}};
 
   IPAddress address;
   for (const auto& test : tests) {
     EXPECT_TRUE(address.AssignFromIPLiteral(test.address));
+    ASSERT_TRUE(address.IsValid());
     EXPECT_EQ(!!test.is_reserved, address.IsReserved());
   }
 }
 
 // Tests for the reserved IPv6 ranges and the (unreserved) blocks in between.
 // The reserved ranges are tested by checking the first and last address of each
 // range. The unreserved blocks are tested similarly. These tests cover the
 // entire IPv6 address range.
 TEST(IPAddressTest, IsReservedIPv6) {
   struct {
@@ skipping 210 matching lines @@
   IPAddress ip_address2;
   EXPECT_TRUE(ip_address2.AssignFromIPLiteral("2001:db8:0::42"));
   EXPECT_TRUE(ip_address1 < ip_address2);
   EXPECT_FALSE(ip_address2 < ip_address1);
 
   // Compare equivalent addresses.
   IPAddress ip_address3;
   EXPECT_TRUE(ip_address3.AssignFromIPLiteral("127.0.0.1"));
   EXPECT_FALSE(ip_address1 < ip_address3);
   EXPECT_FALSE(ip_address3 < ip_address1);
+
+  IPAddress ip_address4;
+  EXPECT_TRUE(ip_address4.AssignFromIPLiteral("128.0.0.0"));
+  EXPECT_TRUE(ip_address1 < ip_address4);
+  EXPECT_FALSE(ip_address4 < ip_address1);
 }
 
 // Test mapping an IPv4 address to an IPv6 address.
 TEST(IPAddressTest, ConvertIPv4ToIPv4MappedIPv6) {
   IPAddress ipv4_address(192, 168, 0, 1);
   IPAddress ipv6_address = ConvertIPv4ToIPv4MappedIPv6(ipv4_address);
 
   // ::ffff:192.168.0.1
   EXPECT_EQ("0,0,0,0,0,0,0,0,0,0,255,255,192,168,0,1",
             DumpIPAddress(ipv6_address));
@@ skipping 160 matching lines @@
 
   // Prefix is longer than the address.
   uint8_t ipv6_prefix5[] = {42, 0, 20, 80, 64, 12, 12, 9, 0,
                             0,  0, 0,  0,  0,  0,  0,  10};
   EXPECT_FALSE(IPAddressStartsWith(ipv6_address, ipv6_prefix5));
 }
 
 }  // anonymous namespace
 
 }  // namespace net