Avoid heap allocations in IPAddress

content/public/common/common_param_traits.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/common/common_param_traits.h"
 
 #include <string>
 
+#include "base/containers/stack_container.h"
 #include "content/public/common/content_constants.h"
 #include "content/public/common/page_state.h"
 #include "content/public/common/referrer.h"
 #include "net/base/host_port_pair.h"
 #include "net/base/ip_address.h"
 #include "net/base/ip_endpoint.h"
 
 namespace IPC {
 
 void ParamTraits<url::Origin>::GetSize(base::PickleSizer* s,
@@ skipping 98 matching lines @@
   *p = net::IPEndPoint(address, port);
   return true;
 }
 
 void ParamTraits<net::IPEndPoint>::Log(const param_type& p, std::string* l) {
   LogParam("IPEndPoint:" + p.ToString(), l);
 }
 
 void ParamTraits<net::IPAddress>::GetSize(base::PickleSizer* s,
                                           const param_type& p) {
-  GetParamSize(s, p.bytes());
+  base::StackVector<uint8_t, 16> bytes;
+  for (uint8_t byte : p.bytes())
+    bytes->push_back(byte);
+  GetParamSize(s, bytes);
 }
 
 void ParamTraits<net::IPAddress>::Write(base::Pickle* m, const param_type& p) {
-  WriteParam(m, p.bytes());
+  base::StackVector<uint8_t, 16> bytes;
+  for (uint8_t byte : p.bytes())
+    bytes->push_back(byte);
+  WriteParam(m, bytes);
 }
 
 bool ParamTraits<net::IPAddress>::Read(const base::Pickle* m,
                                        base::PickleIterator* iter,
                                        param_type* p) {
-  std::vector<uint8_t> bytes;
+  base::StackVector<uint8_t, 16> bytes;
   if (!ReadParam(m, iter, &bytes))
     return false;
-  if (bytes.size() &&
-      bytes.size() != net::IPAddress::kIPv4AddressSize &&
-      bytes.size() != net::IPAddress::kIPv6AddressSize) {
+  if (bytes->size() && bytes->size() != net::IPAddress::kIPv4AddressSize &&
+      bytes->size() != net::IPAddress::kIPv6AddressSize) {
     return false;
   }
-  *p = net::IPAddress(bytes);
+  *p = net::IPAddress(bytes->data(), bytes->size());
   return true;
 }
 
 void ParamTraits<net::IPAddress>::Log(const param_type& p, std::string* l) {
     LogParam("IPAddress:" + (p.empty() ? "(empty)" : p.ToString()), l);
 }
 
 void ParamTraits<content::PageState>::GetSize(base::PickleSizer* s,
                                               const param_type& p) {
   GetParamSize(s, p.ToEncodedData());
@@ skipping 43 matching lines @@
 #undef CONTENT_PUBLIC_COMMON_COMMON_PARAM_TRAITS_MACROS_H_
 #include "content/public/common/common_param_traits_macros.h"
 }  // namespace IPC
 
 // Generate param traits log methods.
 #include "ipc/param_traits_log_macros.h"
 namespace IPC {
 #undef CONTENT_PUBLIC_COMMON_COMMON_PARAM_TRAITS_MACROS_H_
 #include "content/public/common/common_param_traits_macros.h"
 }  // namespace IPC