Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2881663003: Use TaskScheduler instead of SequencedWorkerPool in gcm_profile_service_factory.cc. (Closed)

Created:
3 years, 7 months ago by fdoray
Modified:
3 years, 7 months ago
Reviewers:
fgorski
CC:
chromium-reviews, Peter Beverloo, johnme+watch_chromium.org, zea+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use TaskScheduler instead of SequencedWorkerPool in gcm_profile_service_factory.cc. SequencedWorkerPool is being deprecated in favor of TaskScheduler. BUG=667892 R=fgorski@chromium.org Review-Url: https://codereview.chromium.org/2881663003 Cr-Commit-Position: refs/heads/master@{#472079} Committed: https://chromium.googlesource.com/chromium/src/+/f4de64b20510640bcee42dbc34b9a90341b28467

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M chrome/browser/gcm/gcm_profile_service_factory.cc View 2 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
fdoray
3 years, 7 months ago (2017-05-12 17:07:26 UTC) #1
fdoray
Please take a look. This CL was generated automatically. The base::MayBlock() trait was specified for ...
3 years, 7 months ago (2017-05-12 17:07:29 UTC) #3
fgorski
lgtm Peter, this looks like boilerplate. I verified that traits are appropriate.
3 years, 7 months ago (2017-05-15 22:17:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2881663003/1
3 years, 7 months ago (2017-05-16 00:42:31 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/455211)
3 years, 7 months ago (2017-05-16 02:10:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2881663003/1
3 years, 7 months ago (2017-05-16 12:31:07 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 13:25:25 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f4de64b20510640bcee42dbc34b9...

Powered by Google App Engine
This is Rietveld 408576698