Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: chrome/browser/ui/views/payments/validating_combobox.cc

Issue 2881643002: Focus first invalid field of payment request editor (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/payments/validating_combobox.cc
diff --git a/chrome/browser/ui/views/payments/validating_combobox.cc b/chrome/browser/ui/views/payments/validating_combobox.cc
index d9e26811e9cf88f850f66b0c188e7823ee2bf2b9..fb3c180c7c0235d9ac8c8a6ae87d92493bd15af5 100644
--- a/chrome/browser/ui/views/payments/validating_combobox.cc
+++ b/chrome/browser/ui/views/payments/validating_combobox.cc
@@ -28,7 +28,7 @@ void ValidatingCombobox::OnBlur() {
// removed.
if (!was_blurred_ && !being_removed_) {
was_blurred_ = true;
- Validate();
+ Validate(/*display_error=*/true);
}
}
@@ -44,7 +44,7 @@ void ValidatingCombobox::OnContentsChanged() {
if (!was_blurred_)
return;
- Validate();
+ Validate(/*display_error=*/true);
}
void ValidatingCombobox::OnComboboxModelChanged(
@@ -53,9 +53,9 @@ void ValidatingCombobox::OnComboboxModelChanged(
delegate_->ComboboxModelChanged(this);
}
-void ValidatingCombobox::Validate() {
+void ValidatingCombobox::Validate(bool display_error) {
// ValidateCombobox may have side-effects, such as displaying errors.
- SetInvalid(!delegate_->ValidateCombobox(this));
+ SetInvalid(!delegate_->ValidateCombobox(this, display_error));
}
} // namespace payments

Powered by Google App Engine
This is Rietveld 408576698