chrome/browser/ui/views/payments/shipping_address_editor_view_controller.h - Issue 2881643002: Focus first invalid field of payment request editor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/payments/shipping_address_editor_view_controller.h

Issue 2881643002: Focus first invalid field of payment request editor (Closed)

Patch Set: Rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/payments/payment_request_sheet_controller.cc ('K') | « chrome/browser/ui/views/payments/payment_request_sheet_controller.cc ('k') | chrome/browser/ui/views/payments/shipping_address_editor_view_controller.cc » ('j') | chrome/browser/ui/views/payments/validation_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/payments/shipping_address_editor_view_controller.h

diff --git a/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.h b/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.h

index e9be3ef76c25bd2fd2dd7ff0eef93cc2683fc4ef..a5e8124211d781ad7ad6bc3f7efc8278583b161c 100644

--- a/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.h

+++ b/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.h

@@ -69,12 +69,14 @@ class ShippingAddressEditorViewController : public EditorViewController {

~ShippingAddressValidationDelegate() override;

// ValidationDelegate:

- bool ValidateTextfield(views::Textfield* textfield) override;

- bool ValidateCombobox(views::Combobox* combobox) override;

+ bool ValidateTextfield(views::Textfield* textfield,

+ bool display_error) override;

+ bool ValidateCombobox(views::Combobox* combobox,

+ bool display_error) override;

void ComboboxModelChanged(views::Combobox* combobox) override;

private:

- bool ValidateValue(const base::string16& value);

+ bool ValidateValue(const base::string16& value, bool display_error);

EditorField field_;